Update baselines to allowlist existing by-lazy usages

Test: the _lint_test bazel targets Bug: None Change-Id: I1ea9f97237650fe82bdcb1d8cc710df14f7756ff GitOrigin-RevId: e515f3618cda9e5eae9c242d646a4870b5b9bc8d
jiao123456789 · Jun 3, 2022 · ffea520 · ffea520
1 parent 95191b3
commit ffea520
Show file tree

Hide file tree

Showing 24 changed files with 1,088 additions and 43 deletions.
diff --git a/adt-ui/lint_baseline.xml b/adt-ui/lint_baseline.xml
@@ -1,5 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="5" by="lint 7.0.0-dev">
+<issues format="5" by="lint 7.4.0-dev">
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/main/java/com/android/tools/adtui/InformationPopup.kt"
+            line="153"/>
+    </issue>
+
+    <issue
+        id="JbUiStored"
+        message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes">
+        <location
+            file="src/main/java/com/android/tools/adtui/stdui/CloseButton.java"
+            line="31"/>
+    </issue>
 
     <issue
         id="JbUiStored"
@@ -78,7 +94,7 @@
         message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes">
         <location
             file="src/main/java/com/android/tools/adtui/instructions/InstructionsPanel.java"
-            line="302"/>
+            line="340"/>
     </issue>
 
     <issue
@@ -350,22 +366,15 @@
         message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes">
         <location
             file="src/main/java/com/android/tools/adtui/workbench/WorkBench.java"
-            line="620"/>
+            line="679"/>
     </issue>
 
     <issue
         id="VisibleForTests"
         message="This method should only be accessed from tests or within private scope">
         <location
             file="src/main/java/com/android/tools/adtui/treegrid/TreeGridSpeedSearch.java"
-            line="51"/>
+            line="52"/>
     </issue>
 
-    <issue
-        id="JbUiStored"
-        message="Do not store `JBUI.scale` scaled results in fields; this will not work correctly on dynamic theme or font size changes">
-      <location
-          file="src/main/java/com/android/tools/adtui/stdui/CloseButton.java"
-          line="31"/>
-    </issue>
 </issues>
diff --git a/android-adb/BUILD b/android-adb/BUILD
@@ -5,7 +5,7 @@ iml_module(
     name = "intellij.android.adb",
     srcs = ["src"],
     iml_files = ["intellij.android.adb.iml"],
-    lint_baseline = "//tools/base/lint:studio-checks/empty_baseline.xml",
+    lint_baseline = "lint_baseline.xml",
     resources = ["resources"],
     visibility = ["//visibility:public"],
     # do not sort: must match IML order

diff --git a/android-adb/lint_baseline.xml b/android-adb/lint_baseline.xml
@@ -0,0 +1,108 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="5" by="lint 7.4.0-dev">
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adblib/AndroidAdbLibHost.kt"
+            line="28"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adblib/AndroidAdbLoggerFactory.kt"
+            line="26"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/PairDevicesUsingWiFiService.kt"
+            line="34"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/PairDevicesUsingWiFiService.kt"
+            line="36"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/PairDevicesUsingWiFiService.kt"
+            line="46"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/PairDevicesUsingWiFiService.kt"
+            line="50"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/PairingCodePairingDialog.kt"
+            line="33"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/RandomProvider.kt"
+            line="24"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/ui/SimpleDialog.kt"
+            line="40"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/WiFiPairingNotificationServiceImpl.kt"
+            line="26"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/WiFiPairingPanel.kt"
+            line="33"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/WiFiPairingPanel.kt"
+            line="51"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/adb/wireless/WiFiPairingPanel.kt"
+            line="57"/>
+    </issue>
+
+</issues>
diff --git a/android-common/BUILD b/android-common/BUILD
@@ -5,7 +5,7 @@ iml_module(
     name = "intellij.android.common",
     srcs = ["src"],
     iml_files = ["intellij.android.common.iml"],
-    lint_baseline = "//tools/base/lint:studio-checks/empty_baseline.xml",
+    lint_baseline = "lint_baseline.xml",
     tags = ["no_test_windows"],
     test_class = "com.android.tools.idea.AndroidCommonTestSuite",
     # keep sorted

diff --git a/android-common/lint_baseline.xml b/android-common/lint_baseline.xml
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="5" by="lint 7.4.0-dev">
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/kotlin/AndroidKtPsiUtils.kt"
+            line="90"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/concurrency/FutureUtils.kt"
+            line="143"/>
+    </issue>
+
+</issues>
diff --git a/android-lang/BUILD b/android-lang/BUILD
@@ -10,7 +10,7 @@ iml_module(
         "resources",
     ],
     iml_files = ["intellij.android.lang.iml"],
-    lint_baseline = "//tools/base/lint:studio-checks/empty_baseline.xml",
+    lint_baseline = "lint_baseline.xml",
     visibility = ["//visibility:public"],
     # do not sort: must match IML order
     deps = [

diff --git a/android-lang/lint_baseline.xml b/android-lang/lint_baseline.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="5" by="lint 7.4.0-dev">
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/lang/androidSql/resolution/InternalTables.kt"
+            line="36"/>
+    </issue>
+
+</issues>
diff --git a/android-npw/lint_baseline.xml b/android-npw/lint_baseline.xml
@@ -1,5 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="5" by="lint 7.1.0-dev">
+<issues format="5" by="lint 7.4.0-dev">
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/npw/module/ChooseModuleTypeWizard.kt"
+            line="79"/>
+    </issue>
+
+    <issue
+        id="AvoidByLazy"
+        message="Avoid `by lazy` for simple lazy initialization">
+        <location
+            file="src/com/android/tools/idea/npw/module/ConfigureModuleStep.kt"
+            line="130"/>
+    </issue>
 
     <issue
         id="JbUiStored"
@@ -14,7 +30,7 @@
         message="Do not compare java.io.File with `equals` or `==`: will not work correctly on case insensitive file systems! See `go/files-howto`.">
         <location
             file="src/com/android/tools/idea/npw/assetstudio/wizard/ConfirmGenerateImagesStep.java"
-            line="432"/>
+            line="418"/>
     </issue>
 
 </issues>