Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix job using cargo clippy instead of cargo check #584

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/bors.toml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
status = ["clippy", "build", "build-without-warnings","tests", "functional_tests" ]
status = ["clippy", "build-without-warnings","tests", "functional_tests" ]
13 changes: 5 additions & 8 deletions .github/workflows/build_test_fmt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,25 @@ jobs:
- name: Check the coding style
run: |
cargo fmt -- --check

build:
runs-on: ubuntu-latest
needs: coding-style

steps:
- uses: actions/checkout@v2
- name: Build jinko
run: |
cargo clippy
- name: echo
run: |
echo Hello

build-without-warnings:
runs-on: ubuntu-latest
needs: build

steps:
- uses: actions/checkout@v2
- name: Make sure that the build completes without any warnings
env:
RUSTFLAGS: "-D warnings" # Trigger an error on warnings
run: |
cargo clippy
cargo check

tests-check:
runs-on: ubuntu-latest
Expand Down