-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary GPU Support #61
base: master
Are you sure you want to change the base?
Conversation
@jipolanco I'll work on creating the conditional dependency for CUDA.jl and AMDGPU.jl. Do we have a way to test the GPU code? |
Not yet. I'll contact the JuliaGPU organisation to see if we can use their Buildkite infrastructure. |
@jipolanco why does the |
You're right, there's no reason to include the |
@jipolanco the examples/in-place.jl on my machine works fine if I run it from the root directory project. I think it's best to make the action run it from the root directory instead of the test folder. Is there a reason to have a Project.toml for the |
Yes. Tests and examples use certain extra packages that we do not want to include as PencilFFTs dependencies. After looking at the details, the test failures seem to come from a recent change in FFTW.jl (JuliaMath/FFTW.jl#253), which is actually an improvement. I'll fix this in a separate PR. |
@jipolanco I turned CUDA and AMDGPU into optional dependencies. I tested it on both Julia 1.10 and Julia 1.7. |
…d option to select collective in benchnmarks.jl.
This PR contains my work on enabling GPU support for PencilFFTs.jl.
The tests should work, except some permutations. I need help figuring out what goes wrong in those cases.