ignore if new validator too #612

michaelschem · 2024-04-18T07:00:23Z

Problem

Error says to ignore if you're a hot-spare, but you should also ignore if you're a new validator because you're not yet on the leader schedule.

Summary of Changes

Add some text to the error message.

* Add GHA to close new issues with a comment * Remove trailing whitespace

Add github action to close new pull requests with a comment directing them to agave

* ci: add upload-gcs-artifact * ci: publish release binaries to GCS * ci: redirect github repo to anza-xyz * ci: publish windows binaries to GCS * replace release.solana.com with release.anza.xyz * use a explicit name for credential

* Update README.md * ci: update CodeCov report link * ci: update github pr link * ci: rename secondary pipeline * replace org name in .mergify * update channel info link * update dependabot pr link * use anza docker image * delete travis --------- Co-authored-by: Will Hickey <[email protected]>

* ci: fix windows build * ci: publish sdk docker image with the new name * update automerge status

…foundation#9) ci: removed unused s3 upload in Windows build

* rename geyser-plugin-interface * rename cargo registry * rename watchtower * rename ledger tool * rename validator * rename install * rename geyser plugin interface when patch

…n#58)

jito-foundation#69) * Make inactive_stake consistent * Add rpc_deprecated_v1_18 module * Move get_stake_activation to deprecated list * Fix typo

This reverts commit 3f9a7a5.

jito-foundation#9)" This reverts commit 91e3dd2.

This reverts commit 58e9a19.

This reverts commit b0022d7.

This reverts commit 9355518.

Signed-off-by: gcmutator <[email protected]>

This reverts commit 556a749.

…-foundation#56)

When viewing in various tools such as gdb and perf, it is not easy to distinguish which threads are serving which function (TPU or TPU FWD)

- solTvuFetchPmod ==> solTvuPktMod + solTvuRepPktMod - solSigVerifier ==> solSigVerTpu + solSigVerTpuVot

* Simplify vote-authority display * Add handling for new vote authority * Add proper None handling, because unit test (shouldn't happen IRL, though) * Unwrap->expect

)

* assert simple vote tx const cost

…foundation#116)

* relax stake split destination check * change stake_account error handling logic * fmt * modify logic * change error message when account is neither owned by stake program or system program * add a comment explaining nested ifs in stake_account error handling * fix typos in comments * update comment

…rtext`, and `AeCiphertext` (jito-foundation#130) * add `ParseError` in `zk-token-elgamal` * implement `FromStr` for `ElGamalPubkey` and `ElGamalCiphertext` * implement `FromStr` for `AeCiphertext` * fix target * cargo fmt * use constants for byte length check * make `FromStr` functions available on chain * use macros for the `FromStr` implementations * restrict `from_str` macro to `pub(crate)` * decode directly into array * cargo fmt * Apply suggestions from code review Co-authored-by: Jon C <[email protected]> * remove unnecessary imports * remove the need for `ParseError` dependency --------- Co-authored-by: Jon C <[email protected]>

…oundation#254) * Replace AggregateResult with more methods. * Rename slots_to_repair() to slots_to_repair_iter().

* Switch to blockstore.is_full() check because replay thread isn't active. * Use make_chaining_slot_entries and add first_parent to the method. Small style fixes. * Switch to blockstore.is_full() check because replay thread isn't active.

Co-authored-by: HaoranYi <[email protected]>

…on#253) * Clean up require_rent_exempt_split_destination feature * Clean up comment

Co-authored-by: Richard Patel <[email protected]>

fix typo in comment of test_optimistic_confirmation_violation_without_tower

only reroute if relayer connected (jito-foundation#123) feat: add client tls config (jito-foundation#121) remove extra val (jito-foundation#129) fix clippy (jito-foundation#130) copy all binaries to docker-output (jito-foundation#131) Ledger tool halts at slot passed to create-snapshot (jito-foundation#118) update program submodule (jito-foundation#133) quick fix for tips and clearing old bundles (jito-foundation#135) update submodule to new program (jito-foundation#136) Improve stake-meta-generator usability (jito-foundation#134) pinning submodule head (jito-foundation#140) Use BundleAccountLocker when handling tip txs (jito-foundation#147) Add metrics for relayer + block engine proxy (jito-foundation#149) Build claim-mev in docker (jito-foundation#141) Rework bundle receiving and add metrics (jito-foundation#152) (jito-foundation#154) update submodule + dev files (jito-foundation#158) Deterministically find tip amounts, add meta to stake info, and cleanup pubkey/strings in MEV tips (jito-foundation#159) update jito-programs submodule (jito-foundation#160) Separate MEV tip related workflow (jito-foundation#161) Add block builder fee protos (jito-foundation#162) fix jito programs (jito-foundation#163) update submodule so autosnapshot exits out of ledger tool early (jito-foundation#164) Pipe through block builder fee (jito-foundation#167) pull in new snapshot code (jito-foundation#171) block builder bug (jito-foundation#172) Pull in new slack autosnapshot submodule (jito-foundation#174) sort stake meta json and use int math (jito-foundation#176) add accountsdb conn submod (jito-foundation#169) Update tip distribution parameters (jito-foundation#177) new submodules (jito-foundation#180) Add buildkite link for jito CI (jito-foundation#183) Fixed broken links to repositories (jito-foundation#184) Changed from ssh to https transfer for clone Seg/update submods (jito-foundation#187) fix tests (jito-foundation#190) rm geyser submod (jito-foundation#192) rm dangling geyser references (jito-foundation#193) fix syntax err (jito-foundation#195) use deterministic req ids in batch calls (jito-foundation#199) update jito-programs revert cargo update Cargo lock update with path fix fix cargo update autosnapshot with block lookback (jito-foundation#201) [JIT-460] When claiming mev tips, skip accounts that won't have min rent exempt amount after claiming (jito-foundation#203) Add logging for sol balance desired (jito-foundation#205) * add logging * add logging * update msg * tweak vars update submodule (jito-foundation#204) use efficient data structures when calling batch_simulate_bundles (jito-foundation#206) [JIT-504] Add low balance check in uploading merkle roots (jito-foundation#209) add config to simulate on top of working bank (jito-foundation#211) rm frozen bank check simulate_bundle rpc bugfixes (jito-foundation#214) rm frozen bank check in simulate_bundle rpc method [JIT-519] Store ClaimStatus address in merkle-root-json (jito-foundation#210) * add files * switch to include bump update submodule (jito-foundation#217) add amount filter (jito-foundation#218) update autosnapshot (jito-foundation#222) Print TX error in Bundles (jito-foundation#223) add new args to support single relayer and block-engine endpoints (jito-foundation#224) point to new jito-programs submod and invoke updated init tda instruction (jito-foundation#228) fix clippy errors (jito-foundation#230) fix validator start scripts (jito-foundation#232) Point README to gitbook (jito-foundation#237) use packaged cargo bin to build (jito-foundation#239) Add validator identity pubkey to StakeMeta (jito-foundation#226) The vote account associated with a validator is not a permanent link, so log the validator identity as well. bugfix: conditionally compile with debug flags (jito-foundation#240) Seg/tip distributor master (jito-foundation#242) * validate tree nodes * fix unit tests * pr feedback * bump jito-programs submod Simplify bootstrapping (jito-foundation#241) * startup without precompile * update spacing * use release mode * spacing fix validation rm validation skip Account for block builder fee when generating excess tip balance (jito-foundation#247) Improve docker caching delay constructing claim mev txs (jito-foundation#253) fix stake meta tests from bb fee (jito-foundation#254) fix tests Buffer bundles that exceed cost model (jito-foundation#225) * buffer bundles that exceed cost model clear qos failed bundles buffer if not leader soon (jito-foundation#260) update Cargo.lock to correct solana versions in jito-programs submodule (jito-foundation#265) fix simulate_bundle client and better error handling (jito-foundation#267) update submod (jito-foundation#272) Preallocate Bundle Cost (jito-foundation#238) fix Dockerfile (jito-foundation#278) Fix Tests (jito-foundation#279) Fix Tests (jito-foundation#281) * fix tests update jito-programs submod (jito-foundation#282) add reclaim rent workflow (jito-foundation#283) update jito-programs submod fix clippy errs rm wrong assertion and swap out file write fn call (jito-foundation#292) Remove security.md (jito-foundation#293) demote frequent relayer_stage-stream_error to warn (jito-foundation#275) account for case where TDA exists but not allocated (jito-foundation#295) implement better retries for tip-distributor workflows (jito-foundation#297) limit number of concurrent rpc calls (jito-foundation#298) Discard Empty Packet Batches (jito-foundation#299) Identity Hotswap (jito-foundation#290) small fixes (jito-foundation#305) Set backend config from admin rpc (jito-foundation#304) Admin Shred Receiver Change (jito-foundation#306) Seg/rm bundle UUID (jito-foundation#309) Fix github workflow to recursively clone (jito-foundation#327) Add recursive checkout for downstream-project-spl.yaml (jito-foundation#341) Use cluster info functions for tpu (jito-foundation#345) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (jito-foundation#374) Updates bootstrap and start scripts needed for local dev. (jito-foundation#384) Remove Deprecated Cli Args (jito-foundation#387) Master Rebase improve simulate_bundle errors and response (jito-foundation#404) derive Clone on accountoverrides (jito-foundation#416) Add upsert to AccountOverrides (jito-foundation#419) update jito-programs (jito-foundation#430) [JIT-1661] Faster Autosnapshot (jito-foundation#436) Reverts simulate_transaction result calls to upstream (jito-foundation#446) Don't unlock accounts in TransactionBatches used during simulation (jito-foundation#449) first pass at wiring up jito-plugin (jito-foundation#428) [JIT-1713] Fix bundle's blockspace preallocation (jito-foundation#489) [JIT-1708] Fix TOC TOU condition for relayer and block engine config (jito-foundation#491) [JIT-1710] - Optimize Bundle Consumer Checks (jito-foundation#490) Add Blockhash Metrics to Bundle Committer (jito-foundation#500) add priority fee ix to mev-claim (jito-foundation#520) Update Autosnapshot (jito-foundation#548) Run MEV claims + reclaiming rent-exempt amounts in parallel. (jito-foundation#582) Update CI (jito-foundation#584) - Add recursive submodule checkouts. - Re-add solana-secondary step

… against a constant instead of VecDeque::capacity() (jito-foundation#587)

… slack during any failures or success.

Fixes the following bugs in the periodic rebase: Sends multiple messages on failure instead of one Cancels entire job if one branch fails

…il job times out (jito-foundation#597)

…tion#603)

segfaultdoc · 2024-05-27T19:07:51Z

core/src/proxy/block_engine_stage.rs

@@ -173,10 +173,10 @@ impl BlockEngineStage {
            .await
            {
                match e {
-                    // This error is frequent on hot spares, and the parsed string does not work
+                    // This error is frequent on hot spares and on new validators, and the parsed string does not work


@michaelschem can you add context that new validator is not on leader schedule?

willhickey and others added 30 commits March 2, 2024 22:58

Add GHA to close new issues with a comment (#35151)

3b940a4

* Add GHA to close new issues with a comment * Remove trailing whitespace

Update SECURITY.md to direct people to agave (#35399)

a780ffb

Add github action to close new pull requests (#35400)

4b25ab2

Add github action to close new pull requests with a comment directing them to agave

[anza migration] ci: fix path (jito-foundation#8)

d2a4f0f

* ci: fix windows build * ci: publish sdk docker image with the new name * update automerge status

[anza migration] ci: removed unused s3 upload in Windows build (jito-…

ff1d892

…foundation#9) ci: removed unused s3 upload in Windows build

[anza migration] rename crates (jito-foundation#10)

14cb9cf

* rename geyser-plugin-interface * rename cargo registry * rename watchtower * rename ledger tool * rename validator * rename install * rename geyser plugin interface when patch

Adds a bench for hash_account() (jito-foundation#47)

932bcd9

update mio to 0.8.11 (jito-foundation#60)

b63a9af

Adds StartingSnapshotStorages to AccountsHashVerifier (jito-foundatio…

f94752d

…n#58)

blockstore_purge: fix inspect -> inspect_err (jito-foundation#66)

94ed7a3

Rpc: deprecate getStakeActivation and make inactive_stake consistent (

5efc4eb

jito-foundation#69) * Make inactive_stake consistent * Add rpc_deprecated_v1_18 module * Move get_stake_activation to deprecated list * Fix typo

windows: Use vcpkg for openssl dep (jito-foundation#73)

0eb0e7c

Revert "[anza migration] rename crates (jito-foundation#10)"

df57657

This reverts commit 3f9a7a5.

Revert "[anza migration] ci: removed unused s3 upload in Windows build (

e72f6ba

jito-foundation#9)" This reverts commit 91e3dd2.

Revert "[anza migration] ci: fix path (jito-foundation#8)"

4cb7c31

This reverts commit 58e9a19.

Revert "[anza migration] ci (jito-foundation#5)"

6e01a07

This reverts commit b0022d7.

Revert "[anza migration] replace binaries backend (jito-foundation#6)"

9b1243e

This reverts commit 9355518.

ci: disable dependabot (#35430)

cb4ddfb

remove repetitive words (#35434)

556a749

Signed-off-by: gcmutator <[email protected]>

Revert "remove repetitive words (#35434)" (#35436)

e81ecfb

This reverts commit 556a749.

Increases account hash's stack buffer to hold 200 bytes of data (jito…

f6cd7c2

…-foundation#56)

Rename and uniquify QUIC thread names (jito-foundation#28)

4753dca

When viewing in various tools such as gdb and perf, it is not easy to distinguish which threads are serving which function (TPU or TPU FWD)

Give SigVerify and ShredFetch threads unique names (jito-foundation#98)

f3c6c08

- solTvuFetchPmod ==> solTvuPktMod + solTvuRepPktMod - solSigVerifier ==> solSigVerTpu + solSigVerTpuVot

Cli: improve vote-account vote-authority display (jito-foundation#95)

e6a7136

* Simplify vote-authority display * Add handling for new vote authority * Add proper None handling, because unit test (shouldn't happen IRL, though) * Unwrap->expect

frozen-abi: Remove proc_macro_hygiene featurization (jito-foundation#109

1f7e6f2

)

assert simple vote tx const cost (jito-foundation#100)

c954939

* assert simple vote tx const cost

Use tokio directly instead of jsonrpc_server_utils's re-export (jito-…

f944227

…foundation#116)

fix typo (jito-foundation#57)

54b44a3

Nagaprasadvr and others added 25 commits March 15, 2024 22:25

Add in metrics for detecting Redundant Pulls (jito-foundation#199)

274382f

Fix gossip contact trace (jito-foundation#241)

1036abf

wen_restart: replace get_aggregate_result() with more methods (jito-f…

5d72196

…oundation#254) * Replace AggregateResult with more methods. * Rename slots_to_repair() to slots_to_repair_iter().

remove raptor coding experiments (jito-foundation#255)

e80f8fa

fix typos (jito-foundation#247)

00a34d7

Co-authored-by: HaoranYi <[email protected]>

Clean up require_rent_exempt_split_destination feature (jito-foundati…

c85844a

…on#253) * Clean up require_rent_exempt_split_destination feature * Clean up comment

congestion_multiplier as u64 (jito-foundation#267)

4550245

Use static memory layout for all sysvars (jito-foundation#249)

133bd7f

Co-authored-by: Richard Patel <[email protected]>

fix typo (jito-foundation#264)

cdb0d15

fix typo in comment of test_optimistic_confirmation_violation_without_tower

Add more release fixes (jito-foundation#585)

3d1ab05

Fix more release urls (jito-foundation#588)

50085d2

[JIT-1812] Fix blocking mutexs (jito-foundation#495)

1d6b524

[JIT-1711] Compare the unprocessed transaction storage BundleStorage…

3121bfc

… against a constant instead of VecDeque::capacity() (jito-foundation#587)

Automatically rebase Jito-Solana on a periodic basis. Send message on…

55d3aa0

… slack during any failures or success.

Fix periodic rebase jito-foundation#594

873733e

Fixes the following bugs in the periodic rebase: Sends multiple messages on failure instead of one Cancels entire job if one branch fails

Ignore buildkite curl errors for rebasing and try to keep curling unt…

3386f79

…il job times out (jito-foundation#597)

Sleep longer waiting for buildkite to start (jito-foundation#598)

c49aa58

correctly initialize account overrides (jito-foundation#595)

0fba39c

Fix: Ensure set contact info to UDP port instead of QUIC (jito-founda…

f75429b

…tion#603)

Add fast replay branch to daily rebase (jito-foundation#607)

994b7d1

ignore if new validator too

761f356

segfaultdoc reviewed May 27, 2024

View reviewed changes

buffalu force-pushed the master branch 3 times, most recently from 7bc716a to b8605f2 Compare July 23, 2024 23:35

segfaultdoc force-pushed the master branch from b3ca5ec to 1742826 Compare October 18, 2024 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ignore if new validator too #612

ignore if new validator too #612

michaelschem commented Apr 18, 2024

segfaultdoc May 27, 2024

ignore if new validator too #612

Are you sure you want to change the base?

ignore if new validator too #612

Conversation

michaelschem commented Apr 18, 2024

Problem

Summary of Changes

segfaultdoc May 27, 2024

Choose a reason for hiding this comment