AUDIT: 36903 #192
Open
AUDIT: 36903 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 80.70% 80.71% +0.01%
==========================================
Files 91 91
Lines 9944 9953 +9
==========================================
+ Hits 8025 8034 +9
Misses 1919 1919 ☔ View full report in Codecov by Sentry. |
|
Need to remove overlap code from #191 |
ebatsell
approved these changes
Jan 24, 2025
buffalu
reviewed
Jan 24, 2025
| vault_fee_token_account.clone(), | ||
| token_program.clone(), | ||
| ]; | ||
| process_update_vault_balance(program_id, &accounts)?; |
There was a problem hiding this comment.
this can brick minting if gets in state where effective rate isn't ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_update_vaultfirst thing in themint_tofunction. This is the least invasive way of solving this issue, at the cost of some double checking of accountsEntry:
36903 (High) "The vault reward mechanism can be sandwiched by MEV"
UpdateVaultBalance is not strictly required before mint, or other actions involving vault.deposited_tokens, so new depositors can claim an unfairly large portion of rewards. The reports describe a scenario where rewards have been deposited, but the vault balance has not yet been updated. If a new depositor mints tokens before the balance update, they are included in the reward distribution calculation. In this way, they can claim a share of rewards that they did not contribute to.
The following are duplicates of this submission:
37311 "Attackers can steal rewards by depositing, updating vault balance and withdrawing immediately after a large reward is deposited"
27295 "Rewards can be stolen by depositing immediately after reward tokens get sent to vault"
37315 "Theft of Unclaimed Yields Due to Improper Reward Distribution in Vault Program"