Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no auth subscription must only wait for the expected bundle ID. #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serejke
Copy link

@serejke serejke commented May 22, 2024

Overview

When jito-searcher-cli send-bundle is run in no-auth mode, the bundle_results_subscription

let mut bundle_results_subscription = client

emits other searchers' bundles.

The current code subscribes to the only .next() bundle


even though it is not necessarily the signer's bundle.

So the script fails with an error akin to:

Sending bundle failed: SimulationFailure("Kze3b5YyyHCPvD8TRRQUdHuXT1Ch6dmUUPYsaC6qSTfyGzxpkjnGkD8xgCQXyDoAC71FZyuU7aXYzJXAqgJm8QB", Some("A transaction in the bundle failed to execute: [signature=Kze3b5YyyHCPvD8TRRQUdHuXT1Ch6dmUUPYsaC6qSTfyGzxpkjnGkD8xgCQXyDoAC71FZyuU7aXYzJXAqgJm8QB, error=Error processing Instruction 3: custom program error: 0x7d0]"))

(other searcher's failed bundle)

Fix

Expect only the sent bundle by UUID and filter out everything else.

@serejke
Copy link
Author

serejke commented Nov 18, 2024

@mdr0id @dgski hey Jito team, it's been a while this PR is waiting for a code review. I'm doing some personal forks cleanup and was wondering if you could merge it any time soon, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant