-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memoization] fix incorrect credentials asynchronous loop #11
[memoization] fix incorrect credentials asynchronous loop #11
Conversation
…iption to the readme. Added some pitfalls I’ve faced to the readme too.
It turned out that WKWebview does not need this POD or NSUrlProtocol hooks.
[self.webView loadRequest: request]; | ||
} | ||
|
||
#pragma mark - JAHPAuthenticatingHTTPProtocolDelegate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as before. I don't think we should mention JAHPAuthenticatingHTTPProtocolDelegate
in this implementation because it isn't needed. I think it'll only confuse people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. This looks good. Are you ready to merge?
It seems like this is a combination of the other two PRs, so maybe you should close them? |
Indeed, it has a few commits on top of those previous ones as I've mentioned in the description. They will be automatically closed by github when this one gets merged. |
Based on #10
Fixed an issue for the case when wrong credentials are entered by the user.
My memoization fix #9 has caused it.
The issue has been fixed for both the existing
UIWebView
based demo and for theWKWebView
one.Issue description
The page would not end up loading since wrong credentials will constantly be provided to the authentication challenge callback. For this reason, the credentials alert would not show up (since the credentials have been memoized but they are wrong).
The fix
webViewDidFinishLoad:
If not marked, the alert will show up all over again until cancelled by the user (as it had before).