Configure log level and log-color via commandline #14
Conversation
|
Much better than exporting LOG_COLORS in environment. I just have a small question about aesthetics.. bold vs light. Interestingly, Terraform CLI does actually the opposite, by default colours are enabled. Anyway, I prefer having them disabled by default because this tool will be mainly used in automated environments. |
| @@ -76,9 +76,15 @@ def find_tf_file(basedir): | |||
| @click.option('--no-clean', 'no_clean', is_flag=True, | |||
| help="Don't clean the environment when the tests finish. " | |||
| "This is useful for debug and troubleshooting.") | |||
| def cli(test, path, tfvar, snapshots, no_clean): | |||
| @click.option('--loglevel', 'loglevel', type=click.Choice([ | |||
| 'CRITICAL', 'ERROR', 'WARNING', 'INFO', 'DEBUG']), | |||
There was a problem hiding this comment.
why reinvent the wheel ? https://docs.python.org/3.1/library/logging.html#logging-levels
There was a problem hiding this comment.
it's not reinventing the wheel. These codes are passed to the python logger later, which is exactly the link you pasted. See this line
This just allows the user to select which log level to display.
There was a problem hiding this comment.
I thought something like this pallets/click#605 , but looks like it is not supported yet ...
|
LGTM |
cfconrad
force-pushed
the
log_level_param
branch
from
8b0cb51
to
c96bb7d
Compare
Introduce new parameter options
--logleveland--log-color