Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team_fielding_bref() can be improved for better parameter formatting and error handling #462

Open
ajaviya opened this issue Nov 22, 2024 · 0 comments

Comments

@ajaviya
Copy link

ajaviya commented Nov 22, 2024

If a user inputs a valid three letter abbreviation for a team when calling team_fielding_bref(), but without all letters capitalized (ex. "oak" or "OaK" instead of "OAK"), it raises the error: AttributeError: 'NoneType' object has no attribute 'find'

Additionally, there is error handling if a user does not input a start_season, but no error handling if a user inputs an invalid range (ex. end season before start season).

I would like to propose adding .upper() to the variable, team, and adding error handling for the season parameter range to increase the robustness of this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant