Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<closed> #464

Closed
wants to merge 1 commit into from
Closed

Conversation

nspihlman
Copy link

Pull request addressing the issue raised in #462 . Updating team_pitching_bref, team_batting_bref, and team_fielding_bref with 2 changes each:

  • Use the .upper() method on the team abbreviation so the query will work for team abbreviations passed in regardless of case.
  • Check that the end_season is not < start_season. If it is, throw a value error.

@nspihlman nspihlman closed this Dec 3, 2024
@nspihlman nspihlman deleted the fixup-team-bref-methods branch December 3, 2024 03:22
@nspihlman nspihlman changed the title Fixing up team bref methods <closed> Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant