Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix for dates #112

Merged
merged 1 commit into from
May 23, 2022
Merged

add fix for dates #112

merged 1 commit into from
May 23, 2022

Conversation

jmriego
Copy link
Owner

@jmriego jmriego commented May 23, 2022

Problem

Fix the load of date fields as described in #77

Proposed changes

Just adding the right column formats and tests

Types of changes

What types of changes does your code introduce to target-bigquery?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@jmriego jmriego temporarily deployed to Integrate Pull Request May 23, 2022 19:27 Inactive
@jmriego jmriego temporarily deployed to Integrate Pull Request May 23, 2022 19:27 Inactive
@jmriego jmriego temporarily deployed to Integrate Pull Request May 23, 2022 19:27 Inactive
@jmriego jmriego merged commit 8206827 into master May 23, 2022
@jmriego jmriego deleted the datefix branch May 23, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant