Merge branch 'develop'

* develop: setEnable only button
jmulet · Dec 1, 2024 · 5acd672 · 5acd672
2 parents a18cfcb + 6a21bc1
commit 5acd672
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/amd/build/commands.min.js b/amd/build/commands.min.js
diff --git a/amd/build/commands.min.js.map b/amd/build/commands.min.js.map
diff --git a/amd/src/commands.js b/amd/src/commands.js
@@ -43,30 +43,25 @@ export const getSetup = async() => {
         // Register the Icon.
         editor.ui.registry.addIcon(icon, buttonImage.html);
 
-        // Disable button and menu item until the content has been set.
-        const onSetup = (api) => {
-            const cb = () => api.setEnabled(true);
-            editor.on('SetContent', cb);
-            return () => editor.off('SetContent', cb);
-        };
-
         // Register the Toolbar Button.
         editor.ui.registry.addButton(component, {
             icon,
             tooltip: pluginName,
             onAction: () => handleAction(editor),
             enabled: false,
-            onSetup
+            onSetup: (api) => {
+                const cb = () => api.setEnabled(true);
+                editor.on('SetContent', cb);
+                return () => editor.off('SetContent', cb);
+            }
         });
 
         // Add the Menu Item.
         // This allows it to be added to a standard menu, or a context menu.
         editor.ui.registry.addMenuItem(component, {
             icon,
             text: pluginName,
-            onAction: () => handleAction(editor),
-            enabled: false,
-            onSetup
+            onAction: () => handleAction(editor)
         });
     };
 };