Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global variable to configure datasets directory #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoRiF
Copy link

@KoRiF KoRiF commented Oct 26, 2021

this allows to load CIFAR10 & CIFAR100 datasets from the arbitrary location

by default, directory initialized as empty string, so this should not affects on the existing logic

usage:

`
...
uses neuraldatasets; //usual import
//initialization
neuraldatasets.directory := '..\..\Data\cifar-10-batches-bin'; // path to CIFAR-10* //including trailing path delimiter

`

@joaopauloschuler
Copy link
Owner

The main idea is good. It's against my religion to have global variables. So, I'll implement your solution passing parameters.

@KoRiF
Copy link
Author

KoRiF commented Oct 27, 2021 via email

@joaopauloschuler
Copy link
Owner

The request is valid and I'm still considering it.

@joaopauloschuler joaopauloschuler self-assigned this Nov 18, 2021
@joaopauloschuler joaopauloschuler added the enhancement New feature or request label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants