Implement Storage.release_lock

celery_dedupe/storage/base.py

@@ -15,4 +15,10 @@ def obtain_lock(self, key, value):
         Responsible for obtaining a lock for the task
         :returns boolean: Whether lock could be obtained or not
         '''
-        raise NotImplementedError
+        raise NotImplementedError('Storages must implement obtain_lock method')
+
+    def release_lock(self, key):
+        '''
+        Responsible for releasing a lock
+        '''
+        raise NotImplementedError('Storages must implement release_lock method')

celery_dedupe/storage/redis.py

@@ -19,3 +19,5 @@ def obtain_lock(self, key, value):
 
         return obtained
 
+    def release_lock(self, key):
+        self.connection.delete(key)

tests/test_storages.py

@@ -28,3 +28,10 @@ def test_already_locked(self):
         self.redis.setex(key, '1', 10)
         storage = RedisStorage(self.redis, expiry=10)
         assert not storage.obtain_lock(key, '1')
+
+    def test_release_lock(self):
+        key = uuid4()
+        self.redis.setex(key, '1', 10)
+        storage = RedisStorage(self.redis, expiry=10)
+        storage.release_lock(key)
+        assert not self.redis.get(key)