fix lints

.github/ISSUE_TEMPLATE/bug_report.md

@@ -24,15 +24,15 @@ A clear and concise description of what you expected to happen.
 If applicable, add screenshots to help explain your problem.
 
 **Desktop (please complete the following information):**
- - OS: [e.g. iOS]
- - Browser [e.g. chrome, safari]
- - Version [e.g. 22]
+- OS: [e.g. iOS]
+- Browser [e.g. chrome, safari]
+- Version [e.g. 22]
 
 **Smartphone (please complete the following information):**
- - Device: [e.g. iPhone6]
- - OS: [e.g. iOS8.1]
- - Browser [e.g. stock browser, safari]
- - Version [e.g. 22]
+- Device: [e.g. iPhone6]
+- OS: [e.g. iOS8.1]
+- Browser [e.g. stock browser, safari]
+- Version [e.g. 22]
 
 **Additional context**
 Add any other context about the problem here.

.github/scripts/generate-uml.bash

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 # repo root at ../.. from this file's directory
-root=$(realpath $(dirname $(realpath $0))/../..)
+root="$(realpath "$(dirname "$(realpath "$0")")/../..")"
 
 docs_dir="$root/docs/uml"
 
@@ -16,13 +16,13 @@ prev_update="$(git log -n 1 --pretty=format:%H -- "$docs_dir")"
 # regenerated
 declare -A dirty
 # get all directories that have changed since prev_update
-for changed in $(git diff --name-only $prev_update \
+for changed in $(git diff --name-only "$prev_update" \
     | grep --extended-regexp '(flutter_common|core|designer_v2|app)/lib/.*\.dart' \
     | xargs dirname \
     | sort --unique \
 ); do
     # set changed dir as dirty for all parents until we reach lib
-    while [[ -n $(grep --extended-regexp '[^/]*/lib' <<< "$changed") ]]; do
+    while grep --extended-regexp -q '[^/]*/lib' <<< "$changed"; do
         dirty[$changed]=1
         changed="$(dirname "$changed")"
     done
@@ -45,10 +45,10 @@ for d in "${!dirty[@]}"; do
     echo "Generating diagram for $d"
 
     # ensure destination dir extists
-    mkdir -p $(dirname "$out")
+    mkdir -p "$(dirname "$out")"
 
     # go to package dir, i.e. first path component
-    cd "$root/$(cut -d/ -f1 <<< "$d")"
+    cd "$root/$(cut -d/ -f1 <<< "$d")" || exit
     # uml generator gets confused with generated files so we have to remove
     # them
     find . -type f -name '*.g.dart' -exec rm {} \;
@@ -58,7 +58,7 @@ for d in "${!dirty[@]}"; do
         --exclude=State --exclude=StatefulWidget --exclude=StatelessWidget \
         -b nomnoml \
         -s "$(cut -d/ -f2- <<< "$d")" \
-        > $tmpf
+        > "$tmpf"
     npx --yes nomnoml "$tmpf" "$out"
 
     # get deleted generated files back from git

.github/workflows/deploy-apps.yml

@@ -21,7 +21,7 @@ jobs:
         with:
           workflowId: 'publish_pubdev.yml'
       - name: Get the tag name
-        run: echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
+        run: echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV"
       - name: Checkout code
         uses: actions/checkout@v3
       - name: Set up ruby env

.github/workflows/e2e_tests.yml

@@ -31,7 +31,7 @@ jobs:
           docker compose -f docker/supabase/docker-compose.yml up -d
           docker compose -f docker/proxy/docker-compose-proxy.yml up -d
           while [ "$(docker inspect --format='{{.State.Health.Status}}' supabase-db)" != "healthy" ]; do sleep 1; done
-          cat ./database/app_config.sql.example | docker exec -i supabase-db psql -U postgres -d postgres
+          docker exec -i supabase-db psql -U postgres -d postgres < ./database/app_config.sql.example
 
       - name: Start Chrome Driver
         run: |

.github/workflows/release_app.yml

@@ -16,7 +16,7 @@ jobs:
         with:
           workflowId: 'publish_pubdev.yml'
       - name: Get the tag name
-        run: echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
+        run: echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV"
       - name: Checkout code
         uses: actions/checkout@v3
       - name: Decrypt files

CONTRIBUTING.md

@@ -22,7 +22,7 @@ executing Melos scripts. Use `melos <script>` to run scripts from the
 the [Melos documentation](https://melos.invertase.dev/)
 
 When developing locally, you might need to host your own Supabase instance. For
-this, follow the instructions [here](/docker/README.md).
+this, follow the instructions [here](docker/README.md).
 
 ## Repository Overview
 

docker/supabase/scripts/dump_data.sh

@@ -8,7 +8,7 @@ env_file="../.env"
 if [ -f "$env_file" ]; then
   # Source the .env file to set environment variables
   set -a
-  # shellcheck source=../.env
+  # shellcheck disable=SC1090
   . "$env_file"
   set +a
 else

docker/supabase/scripts/dump_schema.sh

@@ -18,7 +18,7 @@ env_file="../.env"
 if [ -f "$env_file" ]; then
   # Source the .env file to set environment variables
   set -a
-  # shellcheck source=../.env
+  # shellcheck disable=SC1090
   . "$env_file"
   set +a
 else

docker/supabase/scripts/execute_sql.sh

@@ -7,7 +7,7 @@ env_file="../.env"
 if [ -f "$env_file" ]; then
   # Source the .env file to set environment variables
   set -a
-  # shellcheck source=../.env
+  # shellcheck disable=SC1090
   . "$env_file"
   set +a
 else
@@ -38,10 +38,7 @@ sql_file="$1"
 docker cp "$sql_file" "$POSTGRES_HOST:/tmp/"
 
 # Connect to the PostgreSQL database and execute the SQL file from within the container
-docker exec -i "$POSTGRES_HOST" psql -h "$container_ip" -U "$db_username" -d "$POSTGRES_DB" -c "\i /tmp/$(basename "$sql_file")" > execute_supabase_sql_output.txt 2>&1
-
-# Check the exit code to see if the SQL script execution was successful
-if [ $? -eq 0 ]; then
+if docker exec -i "$POSTGRES_HOST" psql -h "$container_ip" -U "$db_username" -d "$POSTGRES_DB" -c "\i /tmp/$(basename "$sql_file")" > execute_supabase_sql_output.txt 2>&1; then
   echo "SQL script executed successfully."
 else
   echo "SQL script execution failed."

docs/README.md

@@ -15,7 +15,7 @@ update
   [`db-docs.yml`](../.github/workflows/db-docs.yml) workflow
 - UML diagrams for all dart code in [uml/](uml), organized in directories
   analogous to the file structure of the code, generated by the
-  [`uml-docs.yml`](../.github/workflow/uml-docs.yml) workflow
+  [`uml-docs.yml`](../.github/workflows/uml-docs.yml) workflow
 
 These documentation updates are committed to your branch while you are working
 on it, meaning you should pull and rebase where appropriate to keep a clean