Try to fix issue #991 #1041
Closed
Try to fix issue #991 #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
|
Sure but there's some test failure like |
|
Are they because of the changes proposed in the PR?
…On Fri 17 Mar 2023, 14:20 vrqq, ***@***.***> wrote:
Sure but there's some test failure like std::hash<path> and build scripts.
—
Reply to this email directly, view it on GitHub
<#1041 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFTGNYH2XJQPQFKFA2U7DDW4RXJXANCNFSM6AAAAAAVWQA6VM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, the code in issue 991 still have some problem, and I try to re-fix it here. ( #991 (comment))
Still some test failed. (see the issue previous)