Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecated libraries #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tancnle
Copy link
Contributor

@tancnle tancnle commented Jun 1, 2018

Description

Remove no-longer maintained/deprecated libraries

/cc @johnmichel

@tancnle
Copy link
Contributor Author

tancnle commented Dec 26, 2018

@johnmichel Is there any chance you can have a look at this PR? It has been a while.

@Semigradsky
Copy link

Why you want to remove them?

@wumpus
Copy link

wumpus commented Feb 1, 2019

Removing obsolete libs from the detector makes web archives people sad.

@tancnle
Copy link
Contributor Author

tancnle commented Apr 19, 2019

The motivations are:

  • Some of those URL references no longer exist (i.e. clicking on library icon results on 404 page)
  • Reduce libraries.js size

@nettrino
Copy link

nettrino commented Nov 1, 2021

+1 on not removing deprecated libraries. This information is useful as it lets us know of websites without outdated dependencies and/or security issues. It would actually be useful to have a special icon next to the library to denote its deprecated. For the purposes of this PR perhaps we could turn this into an option where the user can choose to load or not load deprecated libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants