-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interpolate option #419
Add interpolate option #419
Conversation
I believe this doesn't solve the problem I see with the code: when using interpolation and cast together you'll get unexpected error. Minimal example:
|
Hey @WTK Thanks for the comment, I think it would be worth creating another PR to fix the issue you are mentioning. |
@sergeyklay I see you are now the main contributor with push access to this repository, would you mind merging this simple PR ? It just makes interpolate works like it is supposed to be. It doesn't create new errors or anything like that. |
aaaa07c
to
354cd67
Compare
Rebased to fix the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@David-Wobrock I've been looking through your pull request and in principle, everything looks good. However, there seem to be a few builds that failed, notably the code style checks and linters. Could you please make the necessary adjustments? It would greatly assist in maintaining our codebase's quality and readability. Also, I would appreciate it if you could add an entry in the changelog about these changes as well as update corresponding article https://github.com/joke2k/django-environ/blob/main/docs/tips.rst#proxy-value. This would save me some time and ensure that we keep our documentation up to date.
354cd67
to
120d030
Compare
The argument is already documented but not implemented yet. Fixes joke2k#415
120d030
to
8c1b1c1
Compare
Hi @sergeyklay Thanks for your input 👍
I adapted the code ✔️ We should be good now (linting passes locally).
Done ✔️
From my understanding, everything is already documented in the tips section. |
Thank you! |
@David-Wobrock Thank you for your contribution to the project. Unfortunately, after implementing your interpolation solution, we've encountered issues from our users. Due to this, we've decided to revert your changes and release a patch version. This is not a reflection on the quality of your code or idea; it's just that it has caused some complications in this particular context. |
The argument is already documented but not implemented yet.
Fixes #415