Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #2: Added support for Excel files. #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix issue #2: Added support for Excel files. #22

wants to merge 3 commits into from

Conversation

haicanberra
Copy link

Closes #2

  • Added support for Excel files.

Checklist

  • Add and pass tests.
  • Check linting

@jonbiemond
Copy link
Owner

Thanks for the pull request @haicanberra!

Looks like the CI failed because pandas is not included in the project dependencies. On that note I wonder if there's a way to implement Excel support without using pandas, it's such a large package. Let me know if you have any ideas.

jonbiemond
jonbiemond requested changes Mar 26, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbiemond jonbiemond jonbiemond requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Excel files
2 participants
@haicanberra @jonbiemond