Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the client id in the model cleanCache function #347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove the client id in the model cleanCache function #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba555d8
Remove the client id in the model cleanCache function
laoneo Dec 19, 2024
6999934
more
laoneo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions migrations/54-60/removed-backward-incompatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,8 @@ echo $article->get('title');
$article = $app->bootComponent('content')->getMVCFactory()->createModel('Article', 'Administrator')->getItem(1);
echo $article->title;
```

### Client id attribute removed in form models cleanCache function

- PR: https://github.com/joomla/joomla-cms/pull/44637
- Description: The `cleanCache` function doesn't use the `$clientId` attribute anymore since 4.0. This pr removes the leftovers in various models which do extend the `BaseDatabaseModel` `cleanCache` function. If you extend one of these models and do overwrite the `cleanCache` function, remove the `$clientId` attribute.