Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app instances in plugins for layout overrides #350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Dec 20, 2024

User description

joomla/joomla-cms#44647


PR Type

Documentation


Description

  • Added migration documentation for the removal of $app variable in plugins, specifically in the plugins/tmpl folder
  • Provided clear guidance on using $this->getApplication() instead of $this->app
  • Included code examples to demonstrate the correct migration path
  • Referenced the related PR for further context

Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Document removal of app variable in plugins layout overrides

migrations/54-60/removed-backward-incompatibility.md

  • Added documentation about the removal of $app variable in plugins
  • Explained the replacement of $this->app with $this->getApplication()
  • Included code examples showing the old and new way to access the
    application instance
  • +13/-0   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Clarity
    The migration guide should clarify if this change affects all plugin types or specific ones, and whether this is a breaking change that requires immediate action

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant