Skip to content

Add deprecation note for joomla/joomla-cms#45695 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jul 6, 2025

PR Type

Documentation for joomla/joomla-cms#45695


Description

  • Add deprecation note for $app property in Fields Plugin

  • Document replacement with $this->getApplication() method

  • Update migration documentation for Joomla 5.4-6.0


Changes diagram

flowchart LR
  A["Fields Plugin $app property"] -- "deprecated" --> B["$this->getApplication() method"]
  B -- "documented in" --> C["Migration Guide"]
Loading

Changes walkthrough 📝

Relevant files
Documentation
new-deprecations.md
Document Fields Plugin `$app` property deprecation             

migrations/54-60/new-deprecations.md

  • Add new section documenting $app property deprecation
  • Specify replacement method $this->getApplication()
  • Reference specific file path for the deprecated property
  • +4/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    qodo-merge-pro bot commented Jul 6, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Grammar Error

    The sentence contains grammatical errors that make it unclear. The phrase "Instead of use" should be "Instead, use" and the sentence structure needs improvement for clarity.

    Replacement: The `$this->app` property is deprecated in the fields plugins. Instead of use `$this->getApplication()` when the plugin is converted to service providers.

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 6, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix grammatical error in sentence

    Fix the grammatical error in the sentence. The phrase "Instead of use" should be
    "Instead, use" to make the sentence grammatically correct and more readable.

    migrations/54-60/new-deprecations.md [17]

    -Replacement: The `$this->app` property is deprecated in the fields plugins. Instead of use `$this->getApplication()` when the plugin is converted to service providers.
    +Replacement: The `$this->app` property is deprecated in the fields plugins. Instead, use `$this->getApplication()` when the plugin is converted to service providers.
    • Apply / Chat
    Suggestion importance[1-10]: 4

    __

    Why: The suggestion correctly identifies and fixes a grammatical error ("Instead of use" to "Instead, use"), which improves the readability of the documentation file.

    Low
    • Update

    @HLeithner
    Copy link
    Member

    Your deprecation PR (which btw. is not linked here in the description) is for 5.4, which means the deprecation notice in the manual have to go into 5.3 -> 5.4 section.

    @heelc29
    Copy link
    Contributor Author

    heelc29 commented Jul 6, 2025

    Your deprecation PR (which btw. is not linked here in the description) is for 5.4, which means the deprecation notice in the manual have to go into 5.3 -> 5.4 section.

    Shit ... your right

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants