-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Build process: Change Dart-Sass to new API #44659
Conversation
Co-authored-by: Richard Fath <[email protected]>
I have tested this item ✅ successfully on 37b0dfa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44659. |
I have tested this item ✅ successfully on 37b0dfa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44659. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44659. |
Summary of Changes
The Dart-Sass engine has a "new" API, where instead of
renderSync
and a configuration object, it just usescompile()
with the filename instead. As far as I can see, this PR fixes that deprecation warning. Since this only affects our build process, I would consider this to be safe for adoption in 5.2.Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed