Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][bug] Codemirror duplicated assets entries #44674

Open
wants to merge 15 commits into
base: 5.2-dev
Choose a base branch
from
Open

[5.2][bug] Codemirror duplicated assets entries #44674

Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4ae7e36
Update build-codemirror.es6.js
dgrammatiko Dec 28, 2024
baff145
Update build-codemirror.es6.js
dgrammatiko Dec 28, 2024
d2375ec
Update build-codemirror.es6.js
dgrammatiko Dec 28, 2024
2152bf2
Update build-codemirror.es6.js
dgrammatiko Dec 28, 2024
d274b79
Update resolve-package.es6.js
dgrammatiko Dec 30, 2024
c1cafb4
Update build-codemirror.es6.js
dgrammatiko Dec 30, 2024
3ef26b0
Update resolve-package.es6.js
dgrammatiko Dec 30, 2024
d0458fe
Update resolve-package.es6.js
dgrammatiko Dec 30, 2024
a3480ff
Update localise-packages.es6.js
dgrammatiko Dec 30, 2024
a5071e9
Update localise-packages.es6.js
dgrammatiko Dec 30, 2024
b5dca1c
Update localise-packages.es6.js
dgrammatiko Dec 30, 2024
09f5daf
Update localise-packages.es6.js
dgrammatiko Dec 30, 2024
56278ad
Update localise-packages.es6.js
dgrammatiko Dec 30, 2024
7cbf244
Update resolve-package.es6.js
dgrammatiko Dec 30, 2024
b057e7c
Update resolve-package.es6.js
dgrammatiko Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions build/build-modules-js/init/common/resolve-package.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ const { existsSync, readdirSync } = require('fs-extra');
*/
module.exports.resolvePackageFile = (relativePath) => {
for (let i = 0, l = module.paths.length; i < l; i += 1) {
const path = module.paths[i];
const fullPath = `${path}/${relativePath}`;
if (existsSync(fullPath)) {
return fullPath;
}
}
const path = module.paths[i];
const fullPath = `${path}/${relativePath}`;
if (existsSync(fullPath)) {
return fullPath;
}
}
richard67 marked this conversation as resolved.
Show resolved Hide resolved

return false;
return false;
};

/**
Expand All @@ -27,7 +27,7 @@ module.exports.resolvePackageFile = (relativePath) => {
* @returns {[]}
*/
module.exports.getPackagesUnderScope = (scope) => {
const cmModules = [];
const cmModules = new Set();

// Get the scope roots
const roots = [];
Expand All @@ -41,9 +41,9 @@ module.exports.getPackagesUnderScope = (scope) => {
// List of modules
roots.forEach((rootPath) => {
readdirSync(rootPath).forEach((subModule) => {
cmModules.push(`${scope}/${subModule}`);
cmModules.add(`${scope}/${subModule}`);
});
});

return cmModules;
return [...cmModules];
};