-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Fix assets for com_scheduler (new install) #44684
base: 5.2-dev
Are you sure you want to change the base?
Conversation
(92, 1, 175, 176, 1, 'com_categories', 'com_categories', '{}'), | ||
(93, 1, 177, 178, 1, 'com_fields', 'com_fields', '{}'), | ||
(94, 1, 179, 180, 1, 'com_workflow', 'com_workflow', '{}'), | ||
(95, 1, 181, 182, 1, 'com_guidedtours', 'com_guidedtours', '{}'), | ||
(96, 18, 130, 131, 2, 'com_modules.module.109', 'Guided Tours', '{}'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use localization keys here? All other extensions are translated to the default language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's possible - it takes the title of the task itself when the task is saved
joomla-cms/administrator/components/com_scheduler/src/Table/TaskTable.php
Lines 170 to 180 in 56c8b84
/** | |
* Method to return the title to use for the asset table. | |
* | |
* @return string | |
* | |
* @since 5.2.3 | |
*/ | |
protected function _getAssetTitle(): string | |
{ | |
return $this->title; | |
} |
It should be the same behavior like eg. modules (also not translated)
joomla-cms/installation/sql/mysql/base.sql
Lines 89 to 109 in 56c8b84
(67, 18, 76, 77, 2, 'com_modules.module.88', 'Latest Actions', '{}'), | |
(68, 18, 78, 79, 2, 'com_modules.module.89', 'Privacy Dashboard', '{}'), | |
(70, 18, 88, 89, 2, 'com_modules.module.103', 'Site', '{}'), | |
(71, 18, 92, 93, 2, 'com_modules.module.104', 'System', '{}'), | |
(72, 18, 96, 97, 2, 'com_modules.module.91', 'System Dashboard', '{}'), | |
(73, 18, 98, 99, 2, 'com_modules.module.92', 'Content Dashboard', '{}'), | |
(74, 18, 100, 101, 2, 'com_modules.module.93', 'Menus Dashboard', '{}'), | |
(75, 18, 102, 103, 2, 'com_modules.module.94', 'Components Dashboard', '{}'), | |
(76, 18, 104, 105, 2, 'com_modules.module.95', 'Users Dashboard', '{}'), | |
(77, 18, 106, 107, 2, 'com_modules.module.99', 'Frontend Link', '{}'), | |
(78, 18, 108, 109, 2, 'com_modules.module.100', 'Messages', '{}'), | |
(79, 18, 110, 111, 2, 'com_modules.module.101', 'Post Install Messages', '{}'), | |
(80, 18, 112, 113, 2, 'com_modules.module.102', 'User Status', '{}'), | |
(82, 18, 114, 115, 2, 'com_modules.module.105', '3rd Party', '{}'), | |
(83, 18, 116, 117, 2, 'com_modules.module.106', 'Help Dashboard', '{}'), | |
(84, 18, 118, 119, 2, 'com_modules.module.107', 'Privacy Requests', '{}'), | |
(85, 18, 120, 121, 2, 'com_modules.module.108', 'Privacy Status', '{}'), | |
(86, 18, 122, 123, 2, 'com_modules.module.96', 'Popular Articles', '{}'), | |
(87, 18, 124, 125, 2, 'com_modules.module.97', 'Recently Added Articles', '{}'), | |
(88, 18, 126, 127, 2, 'com_modules.module.98', 'Logged-in Users', '{}'), | |
(89, 18, 128, 129, 2, 'com_modules.module.90', 'Login Support', '{}'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kostelano It is only possible while installation with your own full install package.
See https://github.com/joomlagerman/joomla/blob/64ac20ce48a6f74a1aa150e478f1a8021ca2798d/installation/sql/mysql/localise.sql
I have tested this item ✅ successfully on 413f3c5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684. |
With new installation. Download full package from: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44684/downloads/81126/ This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684. |
I have tested this item ✅ successfully on 413f3c5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44684. |
Followup Pull Request for Pull Request #42493 and comment #40788 (review) .
Summary of Changes
Fix assets hierarchy of scheduled tasks for new installations of Joomla
Testing Instructions
Check permissions for component
com_scheduler
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Title present and tasks are inherited from component (level 2)
Link to documentations
Please select: