[6.0] Added typehints for new functions from #40613 #44740
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodge-IT
changed the title
HLeithner
reviewed
Jan 17, 2025
tx Harald Co-authored-by: Harald Leithner <[email protected]>
Removed additional "}" from reviewed code change
laoneo
reviewed
Jan 20, 2025
| @@ -825,9 +825,11 @@ public static function getTypes($arrayType = 'objectList', $selectTypes = null, | |||
| * | |||
| * @deprecated 5.3 will be removed in 7.0 | |||
| */ | |||
| public function postStoreProcess(TableInterface $table, $newTags = [], $replace = true) | |||
| public function postStoreProcess(TableInterface $table, $newTags = [], $replace = true): void | |||
There was a problem hiding this comment.
Please remove the :void as well
Suggested change
| public function postStoreProcess(TableInterface $table, $newTags = [], $replace = true): void | |
| public function postStoreProcess(TableInterface $table, $newTags = [], $replace = true) |
There was a problem hiding this comment.
The void is still here. Why did this get merged? Its still a bc break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40613.
Summary of Changes
Add type hints to new functions.
Testing Instructions
Install patch and check for typehint additions in postStoreProcess() and postStore() functions
Actual result BEFORE applying this Pull Request
new function with limited typehint(TableInterface)
Expected result AFTER applying this Pull Request
new function with all required typehints
Link to documentations
Please select: