Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions for matrixFrom* #3371

Merged
merged 8 commits into from
Jan 29, 2025
Merged

Conversation

gwhitney
Copy link
Collaborator

Replaces #3146.

I couldn't figure out how to push a commit to the source branch of #3146, so I have simply recreated the PR from a branch in my fork, with one additional commit updating the type declarations and adding tests as requested in the review for #3146. Should hopefully be ready to merge.

Resolves #3115.

@gwhitney
Copy link
Collaborator Author

The lint errors in this PR look very strange to me; they seem to be generated by prettier. Did mathjs recently change to prettier from eslint, or did I accidentally pick up some configuration change by trying to build on Hudsxn's version of develop? @josdejong please make sure all is well with lint before merging, thanks.

@josdejong
Copy link
Owner

Thanks Glen!

mathjs currently has an eslint setup which uses prettier under the hood, see https://github.com/josdejong/mathjs/blob/develop/.eslintrc.cjs#L40. I find it a bit confusing setup, maybe some day we can replace it with biome for example, I kind of have the idea that the development around eslint is stalling, I regularly have issues not being able to update because certain eslint plugins require an old version of eslint. Anyway, that's for another day.

@josdejong josdejong merged commit b56fbcb into josdejong:develop Jan 29, 2025
8 checks passed
@josdejong
Copy link
Owner

Published now in v14.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definition missing for matrixFrom*
3 participants