-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Svelte 5 #490
Merged
Merged
Upgrade to Svelte 5 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are not reactive ..."
…e-awesome` and `sass`
…vanilla library only
…d support `undefined`
# Conflicts: # package-lock.json # package.json # src/lib/components/modes/treemode/JSONNode.scss
# Conflicts: # package-lock.json
…act versions again
# Conflicts: # package-lock.json # package.json
# Conflicts: # src/lib/components/modals/SortModal.svelte # src/lib/components/modals/TransformModal.svelte # src/lib/components/modes/JSONEditorRoot.svelte # src/lib/components/modes/tablemode/ColumnHeader.svelte # src/lib/components/modes/tablemode/TableMode.svelte # src/lib/components/modes/treemode/TreeMode.svelte
# Conflicts: # package-lock.json # package.json # src/lib/components/modals/SortModal.svelte # src/lib/components/modals/TransformModal.svelte # src/lib/components/modes/JSONEditorRoot.svelte # src/lib/components/modes/tablemode/ColumnHeader.svelte # src/lib/components/modes/tablemode/TableMode.svelte # src/lib/components/modes/treemode/TreeMode.svelte
Ok all is ready 🎉 . Everything still works in Svelte 4 (and 3), which is amazing, and there should be no breaking changes at all. I'll still publish this as a major breaking change since there may be subtle edge cases (just like it this PR itself involved fixing some subtle breaking changes). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
svelte-awesome
androllup-plugin-svelte
. Solution: the dependencies must update their peer requirements to include Svelte 5. See [Feature] - Svelte 5 support RobBrazier/svelte-awesome#1186 (comment).npm run build
. Not a show stopper. Is a known issue, see Svelte 5: Several circular dependencies in client runtime modules sveltejs/svelte#10140. Since this is not critical but just annoying, will mark this as solved for now.main
branchmain
branchmain
branch. The main cause is the recursiveJSONNode
component. It looks like in Svelte 5, the styles are not recursively applied to child instances ofJSONNode
. Solved by defining the recursive styling needed for nested child components using:global
. It would be good to look into an alternative solution that does not require using:global
.warningFilter
in the svelte config. I think this is a bug in the svelte 5 compiler. UPDATE: this workaround is not suitable: when used as a svelte library, this requires the consumer to configure these warningFilters too, but that is not workable.mount
, adding some config invitest.config.js
, and adapting the expected output and snapshots.main
branch by removingon:focus={undefined}
andon:blur={undefined}
, and instead ignore the svelte warninga11y-mouse-events-have-key-events
.postcss
in the Rollup config.peerDependencies
to support svelte 5 and its release candidatesJSONNode
breaks handling of the double click event.updateProps
of the vanilla library not working:this.$set(props)
is removed in Svelte 5.destroy
of the vanilla library doesn't work:this.$destroy()
is deprecated in Svelte 5.^
and resolve all deprecation warnings.JsonEditor
is no longer exported by Svelte 5. Find an alternative solutionTODO: