feat: maintain selection when switching from/to text
mode
#521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve this, we first have to implement two helper functions to convert from a text position to a
JSONSelection
and vice versa: functionfindTextLocation
already exists, and this PR implements a new functionfindSelectionFromTextLocation
.TODO:
findSelectionFromTextLocation
in detail: it must returnKeySelection
,ValueSelection
,AfterSelection
,InsideSelection
, andMultiSelection
TextMode.svelte, extend the function
applyExternalSelectionwith handling the case when
externalSelectionis a
JSONSelection. Use
findTextLocation` there.TreeMode
andTableMode
extend the functionapplyExternalSelection
to handle the case whenexternalSelection
is aJSONSelection
. UsefindSelectionFromTextLocation
there.JSONSelection
toTextSelection