Serialize Peregrin::Book to JSON #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea. The one hesitation I have is that Peregrin currently has very simplistic dependencies, and these are needed for its core functionality. I have a preference for gems with few dependencies. This is useful additional functionality, but not core functionality. Therefore, I wonder if we could make the dependency on the JSON gem optional? I'll sketch out an idea in a code comment — I'm interested in your feedback. If it makes what you want to do more difficult, I'm happy to entertain making JSON a core dependency. |
|
@joseph Looks perfect, and much more ruby-idiomatic than what I wrote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first lines I've ever written in ruby, so please bear with me!