Added automatic mode selection #2168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwoOfTwelve
requested review from
Kr0nox and
tsaglam
and removed request for
Kr0nox
Kr0nox
reviewed
Jan 30, 2025
| @@ -115,6 +120,30 @@ public void runViewer(File zipFile) throws IOException { | |||
| JPlagRunner.runInternalServer(zipFile, this.inputHandler.getCliOptions().advanced.port); | |||
| } | |||
|
|
|||
| private void selectModeAutomatically() throws IOException, ExitException { | |||
There was a problem hiding this comment.
We should quickly discuss if we want to move calls like runViewer(runJPlag()) into their own method like runModeRunAndView(), to make it clearer which mode got auto selected.
Kr0nox
reviewed
Jan 30, 2025
| List<File> inputs = new ArrayList<>(); | ||
| inputs.addAll(List.of(this.inputHandler.getCliOptions().newDirectories)); | ||
| inputs.addAll(List.of(this.inputHandler.getCliOptions().oldDirectories)); | ||
| inputs.addAll(List.of(this.inputHandler.getCliOptions().rootDirectory)); |
There was a problem hiding this comment.
I would say we add the root directory first, just because it seems more logical
Kr0nox
reviewed
Jan 30, 2025
Co-authored-by: Alex | Kronox <[email protected]>
|
|
Adapt readme |
Kr0nox
requested changes
Jan 31, 2025
|
Also update the documentation JPlag/docs/1.-How-to-Use-JPlag.md Lines 120 to 130 in 10306cc Inspiration may be found here #2171 or just redirect to that section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an implicit mode selection. The CLI will now detect the mode based on the input files.
From the documentation of the mode flag:
By default JPlag will automatically select the mode based on your input files. If none are selected the viewer will open on the file select screen. If a single result zip is selected it will be opened in the viewer directly. Otherwise JPlag will run on the submissions in the input files and show the result in the viewer.