Changes NACChannel setHeader to use hex2byte. Fixes #510 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustiza
force-pushed
the
issue/510-nacchannel-header
branch
from
58eb35f to
782b170
Compare
ar
reviewed
May 9, 2023
|
Thank you for the PR. I can't imagine how this PR could fail, but because NACChannel is heavily used in production, I'll wait until we get positive feedback that this change doesn't create problems, or until I manage to test it myself with real traffic. |
|
Definitely! I wouldn't expect otherwise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this one.
#510