llvm-box: change the argv taken by llvm-box main entry #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27
It looks like llvm-box currently takes the first argument,
argv[0]
, as the command. I'm not sure if this is intentional or if it's just a bug. In most environments, we would probably use it this way:In this case,
argv[1]
isclang
, which is the command we really want. For most operating systems, as well as emscripten'scallMain
method,llvm-box
is automatically added asargv[0]
. So I'm not sure if the way it's currently written is intentional or not? It looks like we have to explicitly call the_main
function and construct a sequence of arguments like thisclang main.cpp