Skip to content

Commit

Permalink
Build: grunt-jquery-content 3.3.1, gilded-wordpress 1.0.7, Node 18+
Browse files Browse the repository at this point in the history 
Closes #1119
  • Loading branch information
@Krinkle
Krinkle committed Nov 12, 2023
1 parent 0b212a8 commit 52f94a1
Show file tree
Hide file tree
Showing 4 changed files with 767 additions and 560 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/node.js.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@
name: Node.js CI

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
- push
- pull_request

This comment has been minimized.

Sign in to view

Copy link
@mgol

mgol Nov 12, 2023

Member

@Krinkle This will make dependabot PRs run both workflows. We need to exclude its branches, see:
https://github.com/jquery/jquery/pull/5353/files
for what we need here.

This comment has been minimized.

Sign in to view

Copy link
@Krinkle

Krinkle Nov 12, 2023 •
edited
Loading

Author Member

What's the downside of letting running it both ways?

This would only happen when a patch is both stored in a remote branch (i.e. not in your own fork) and also being proposed as a PR. I imagine that most patches are either pushed as remote branch, tested, and then pushed to main. Or, pushed to your own fork, and then PR'ed.

The main idea is to make sure that either way, tests can running.

Excluding bots is fine, but seems harmless?

This comment has been minimized.

Sign in to view

Copy link
@mgol

mgol Nov 13, 2023

Member

It’s just unnecessary double work. In the context of Core dependabot PRs, I found it annoying - doubled checks sometimes make it harder to find what’s useful, we use double the CI resources which slows things down, there’s a higher chance of flakiness, etc.

This comment has been minimized.

Sign in to view

Copy link
@Krinkle

Krinkle Nov 13, 2023

Author Member

I see. There's only one job here though, so maybe not worth hardcoding for content repos.

This comment has been minimized.

Sign in to view

Copy link
@mgol

mgol Nov 13, 2023

Member

OK, fair enough.

jobs:
build:
Expand All @@ -15,8 +13,7 @@ jobs:

strategy:
matrix:
# Old infra requires Node 10
node-version: [10.x, 18.x]
node-version: [18.x, 20.x]

steps:
- name: Install xmllint
Expand Down
21 changes: 8 additions & 13 deletions .github/workflows/spider-check.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,18 @@ on:

jobs:
spider-check:
if: ${{ github.repository_owner == 'jquery' }} # skip on forks
env:
MY_SITE: https://api.jquery.com
runs-on: ubuntu-latest
if: ${{ github.repository_owner == 'jquery' }} # skip on forks
env:
# Site address to crawl
MY_SITE: https://api.jquery.com
steps:
- name: Checkout hydra-link-checker
uses: actions/checkout@v3
with:
repository: jquery/hydra-link-checker
ref: v2.0.0
path: hydra

# Checkout the API repo as well to provide the config for hydra-link-checker
- name: Checkout API repo
- name: Checkout repo
uses: actions/checkout@v3
with:
path: api

- name: Run hydra-link-checker
run: python3 hydra/hydra.py "$MY_SITE" --config api/.github/configs/hydra-config.json
run: |
curl -O https://raw.githubusercontent.com/jquery/hydra-link-checker/v2.0.0/hydra.py
python3 hydra.py "$MY_SITE" --config .github/configs/hydra-config.json
Loading

0 comments on commit 52f94a1

Please sign in to comment.