Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery: Add a self-closed tag back to an example #1264

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

flinti
Copy link
Contributor

@flinti flinti commented Oct 19, 2024

This adds an actual quick-closed tag in this code example, as it is implied by the text that there can be one:

Tags that cannot contain elements may be quick-closed or not:

$( "<img>" );
$( "<input>" );

to

Tags that cannot contain elements may be quick-closed or not:

$( "<img>" );
$( "<input />" );

Copy link

linux-foundation-easycla bot commented Oct 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: flinti / name: Flinti (7e945c5)

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was the original intention of this code snippet and the img element was originally auto-closed; this was erroneously changed in 2f54b03.

Maybe let's auto-close img instead of input again? This will be both closer to the past and would follow the order used in the preceding text.

@flinti
Copy link
Contributor Author

flinti commented Oct 19, 2024

I just changed the PR to close img instead of input

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgol mgol changed the title jQuery(): Add a quick-closed tag for an example in jQuery( html [, ownerDocument ] ) jQuery: Add a self-closed tag back to an example Oct 20, 2024
@mgol mgol merged commit a9c3f49 into jquery:main Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants