Skip to content

Fix(a11y/tabs) : move focusable element from <li> to <a> #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix(a11y/tabs) : move focusable element from <li> to <a> #2366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
317922a
Tabs: update focus elements for accessibility
XinaICBF Aug 18, 2025
a1e23ad
Tabs: Resolve nested interactive controls issue
XinaICBF Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions ui/widgets/tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,27 +411,27 @@ $.widget( "ui.tabs", {
}
} );

this.tabs = this.tablist.find( "> li:has(a[href])" )
this.tabs = this.tablist.find( "> li:has(a[href]) > a" )
.attr( {
role: "tab",
tabIndex: -1
tabindex: -1
} );
this._addClass( this.tabs, "ui-tabs-tab", "ui-state-default" );

this.anchors = this.tabs.map( function() {
return $( "a", this )[ 0 ];
} )
this.tablist.find( "> li:has(a[href])" )
.attr( {
tabIndex: -1
role: "presentation"
} );

this.anchors = this.tabs;
this._addClass( this.tabs, "ui-tabs-tab", "ui-state-default" );
this._addClass( this.anchors, "ui-tabs-anchor" );

this.panels = $();

this.anchors.each( function( i, anchor ) {
var selector, panel, panelId,
anchorId = $( anchor ).uniqueId().attr( "id" ),
tab = $( anchor ).closest( "li" ),
tab = $( anchor ),
originalAriaControls = tab.attr( "aria-controls" );

// Inline tab
Expand Down Expand Up @@ -597,7 +597,7 @@ $.widget( "ui.tabs", {
var options = this.options,
active = this.active,
anchor = $( event.currentTarget ),
tab = anchor.closest( "li" ),
tab = anchor,
clickedIsActive = tab[ 0 ] === active[ 0 ],
collapsing = clickedIsActive && options.collapsible,
toShow = collapsing ? $() : this._getPanelForTab( tab ),
Expand Down Expand Up @@ -658,7 +658,7 @@ $.widget( "ui.tabs", {
}

function show() {
that._addClass( eventData.newTab.closest( "li" ), "ui-tabs-active", "ui-state-active" );
that._addClass( eventData.newTab, "ui-tabs-active", "ui-state-active" );

if ( toShow.length && that.options.show ) {
that._show( toShow, that.options.show, complete );
Expand All @@ -671,12 +671,12 @@ $.widget( "ui.tabs", {
// Start out by hiding, then showing, then completing
if ( toHide.length && this.options.hide ) {
this._hide( toHide, this.options.hide, function() {
that._removeClass( eventData.oldTab.closest( "li" ),
that._removeClass( eventData.oldTab,
"ui-tabs-active", "ui-state-active" );
show();
} );
} else {
this._removeClass( eventData.oldTab.closest( "li" ),
this._removeClass( eventData.oldTab,
"ui-tabs-active", "ui-state-active" );
toHide.hide();
show();
Expand Down Expand Up @@ -835,7 +835,7 @@ $.widget( "ui.tabs", {
index = this._getIndex( index );
var that = this,
tab = this.tabs.eq( index ),
anchor = tab.find( ".ui-tabs-anchor" ),
anchor = tab,
panel = this._getPanelForTab( tab ),
eventData = {
tab: tab,
Expand Down Expand Up @@ -911,3 +911,4 @@ if ( $.uiBackCompat === true ) {
return $.ui.tabs;

} );

Loading