-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dz3 lecture 1 #3
base: master
Are you sure you want to change the base?
Conversation
03-lection1/01-button/button.css
Outdated
@@ -1 +1,80 @@ | |||
/* Стилизация кнопки */ | |||
|
|||
.buttons { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
лишние врапперы в файле стилей блока не описываем, да и в целом он лишний
03-lection1/01-button/button.css
Outdated
|
||
|
||
.button { | ||
width: 189px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
лишнее ограничение ширины
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не хватает паддингов + стилей для оформления текста
03-lection1/01-button/button.css
Outdated
cursor: pointer; | ||
} | ||
|
||
.button__primary { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
создаем модификаторы а не элементы
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и в модификаторах описываем только то что реально надо модифицировать, дублировать стили из блока не надо
03-lection1/01-button/button.css
Outdated
|
||
.button__primary:disabled { | ||
background: #4263EB; | ||
Opacity: 50% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opacity: 0.5;
03-lection1/01-button/button.css
Outdated
background: #2342C0; | ||
} | ||
|
||
.button__primary:disabled { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
на каждый тип кнопки не нужно свой вариант м фоном, достаточно иметь общий стиль для disabled (.button:disabled) с полупрозрачностью + pointer-events: none
|
||
|
||
.accordion { | ||
max-width: 730px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
все свойства можно отсюда унести в .accordion__item, кроме max-width + overflow - они не нужны
|
||
.accordion__item { | ||
display: inline-block; | ||
/* margin-bottom: 8px; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
было верно
} | ||
|
||
.accordion__item { | ||
display: inline-block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block / flex
display: none; | ||
} | ||
|
||
.accordions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это лишний класс, у нас нет блока accordions )
<link rel="stylesheet" href="./accordion.css"> | ||
</head> | ||
<body> | ||
<div class="accordions"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
здесь - класс accordion
</head> | ||
<body> | ||
<div class="accordions"> | ||
<details class="accordion" open> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а на details - accordion__item
<body> | ||
<div class="accordions"> | ||
<details class="accordion" open> | ||
<summary class="accordion__item">Accordion item 1</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accordion__title
@@ -0,0 +1,24 @@ | |||
.footer { | |||
background-color: #FFFFFF; | |||
padding: 72px 383px 136px 417px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по краям паддинги не нужны
No description provided.