add 3-5th tasks of 3rd module #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@ShGKme) для код-ревью. |
|
Решение было обновлено, посмотрим что скажет @ShGKme |
|
Решение было обновлено, посмотрим что скажет @ShGKme |
|
Решение было обновлено, посмотрим что скажет @ShGKme |
ShGKme
requested changes
Jan 23, 2025
Comment on lines
6
to
10
| props: { | ||
| alertData: { | ||
| type: Object, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Этот параметр описан, как необязательный (нет required: true). Но этот компонент не только не имеет смысла без этого параметра (ему нечего выводить), но и упадёт с cannot read property of undefined при попытке вывести alertData.sender_name.
Такие параметры должны быть описаны, как обязательные, так как компонент без них работать не может.
Comment on lines
10
to
14
| props: { | ||
| weatherData: { | ||
| type: Object, | ||
| }, | ||
| }, |
|
Добавляю преподавателя (@ShGKme) для код-ревью. |
ShGKme
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.