Rebase some more upstream changes #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other call sites always provide an Object, so this isolates the inconsistency. UPSTREAM_COMMIT=f95cde5996287897ee290f4a9690742fc944d659
BalanceDuration → BalanceTimeDuration BalancePossiblyInfiniteDuration → BalancePossiblyInfiniteTimeDuration BalanceDurationRelative → BalanceDateDurationRelative UnbalanceDurationRelative → UnbalanceDateDurationRelative This makes it clearer what portion of the duration units the operation operates on; especially since we will represent time durations in normalized form. UPSTREAM_COMMIT=cbec236534791352ca412efd481f858e4e5b436a
BalanceTimeDuration (formerly BalanceDuration) had two code paths tangled up inside of it: one where days always equal 24 hours (duration is not relative to a ZonedDateTime) and one where days may be different from 24 hours (duration is relative to a ZonedDateTime). Splitting these two code paths out into two different AOs makes them both easier to understand and reason about. It also removes the need to manually indicate that BalanceTimeDuration doesn't call into user code, because only BalanceTimeDurationRelative can call into user code. UPSTREAM_COMMIT=0547d29dbdf4c5aa9c2dca3c6072513dc52abe36
Similar to the previous commit, this makes NanosecondsToDays easier to understand and reason about. After splitting BalanceTimeDuration and BalanceTimeDurationRelative, there was only one remaining call site of NanosecondsToDays with a possible non-ZonedDateTime relativeTo, in RoundDuration. Instead, inline the 24-hour day case into the call site. UPSTREAM_COMMIT=dffb9298e0c95c8212a624058652ee7f8dba2cdd
12wrigja
force-pushed
the
spec_rebase_1
branch
from
93365fc to
c848897
Compare
ptomato
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.