Git hooks test

.github/workflows/pull-request-checks.yaml

@@ -11,14 +11,84 @@ on:
       - master
 
 jobs:
-  build:
+  check_version:
+    name: Ensure component commits modify component versions
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/[email protected]
+      name: Checkout repo
+      with:
+        # See https://github.com/actions/checkout#checkout-v2
+        # This will be slow. The intent is to fetch all commits
+        # since the merge-base (the commit where we branched off)
+        # so we can check the git diff against all changed files.
+        # By default, the checkout action only returns the last commit,
+        # There's no native way to do this in the checkout action, so 
+        # we have to fetch the entire history. See
+        # https://github.com/actions/checkout/issues/266#issuecomment-638346893
+        fetch-depth: 0
+    - uses: jitterbit/get-changed-files@v1
+      id: changed_files
+      name: Get changed files
+    # We need to get a diff of the base and HEAD commit below
+    - name: Return base commit
+      id: base_commit
+      uses: actions/github-script@v6
+      with:
+        script: return context.payload.pull_request?.base?.sha
+        result-encoding: string
+    - name: Return HEAD commit
+      id: head_commit
+      uses: actions/github-script@v6
+      with:
+        script: return context.payload.pull_request?.head?.sha
+        result-encoding: string
+    # Diff the changes in the HEAD ref (new branch) against the BASE ref (target branch, e.g. master)
+    # If the changes don't contain modifications to the version, we want to log that fact but not exit early
+    # Once we've checked all files, exit the script if any files failed to modify version
+    - id: git_diff_on_components
+      name: Check git diff for version changes
+      run: |-
+        commit_contained_components_that_did_not_modify_version=0
+        for f in ${{ steps.changed_files.outputs.all }}
+        do
+          ext="${f##*.}"
+          # Only run this check on modified sources or actions, excluding common files
+          if ([[ "$ext" == "js" ]] || [[ "$ext" == "mjs" ]]) && \
+             ([[ "${f}" == *components/**/sources/* ]] || [[ "${f}" == *components/**/actions/* ]]) && \
+             [[ "${f}" != *common*.*js ]] && [[ "${f}" != **/actions/common/* ]] && [[ "${f}" != **/sources/common/* ]]
+          then
+            export BASE_COMMIT=${{steps.base_commit.outputs.result}}
+            export HEAD_COMMIT=${{steps.head_commit.outputs.result}}
+            DIFF=`git diff --unified=0 $BASE_COMMIT...$HEAD_COMMIT ${f}`
+            if [[ ${DIFF} != *"version:"* ]]
+            then
+              echo "You didn't modify the version of ${f}"
+              commit_contained_components_that_did_not_modify_version=1
+            fi
+          fi
+        done
+
+        if [[ $commit_contained_components_that_did_not_modify_version -eq 1 ]]
+        then
+          echo "You need to increment the version on some components. Please see the output above and https://pipedream.com/docs/components/guidelines/#versioning for more information"
+          exit 1
+        fi
+
+
+  spellcheck:
     name: Spellcheck
     runs-on: ubuntu-latest
+
     steps:
     - uses: actions/[email protected]
+      name: Checkout
     - uses: jitterbit/get-changed-files@v1
       id: changed_files
+      name: Get changed files
     - id: md_changed_files
+      name: Spellcheck Markdown files
       run: |-
         files=''
         for f in ${{ steps.changed_files.outputs.all }}
@@ -37,6 +107,8 @@ jobs:
       with:
         source_files: ${{ env.files }}
         task_name: Markdown
+
+
   lint:
     name: Lint Code Base
     runs-on: ubuntu-latest

.gitignore

@@ -5,5 +5,6 @@ gh-md-toc
 .vscode
 .idea
 node_modules
+.eslintcache
 
-.vercel
+.vercel

.husky/.gitignore

@@ -0,0 +1 @@
+_

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npx lint-staged

components/discourse/sources/new-posts/new-posts.mjs

@@ -4,10 +4,10 @@ import discourse from "../../discourse.app.mjs";
 export default {
   name: "New Posts",
   key: "discourse-new-posts",
-  version: "0.1.0",
+  version: "0.1.1",
   type: "source",
   description:
-    "Emits an event every time a new post is added to a topic in one of your chosen categories",
+    "Emit new posts added to a topic in one of your chosen categories",
   ...common,
   props: {
     ...common.props,

components/discourse/sources/new-topics/new-topics.mjs

@@ -4,10 +4,10 @@ import discourse from "../../discourse.app.mjs";
 export default {
   name: "New Topics",
   key: "discourse-new-topics",
-  version: "0.1.0",
+  version: "0.1.1",
   type: "source",
   description:
-    "Emit new events every time a new topic is posted to your chosen categories",
+    "Emit new topics posted to your chosen categories",
   ...common,
   props: {
     ...common.props,

components/discourse/sources/new-users/new-users.mjs

@@ -3,10 +3,10 @@ import common from "../../common.mjs";
 export default {
   name: "New Users",
   key: "discourse-new-users",
-  version: "0.1.0",
+  version: "0.1.1",
   type: "source",
   description:
-    "Emits an event every time a new user is created on your instance",
+    "Emit new event every time a new user is created on your instance",
   ...common,
   hooks: {
     ...common.hooks,

components/github/sources/common-webhook.js

@@ -59,7 +59,7 @@ module.exports = {
     }
 
     if ("zen" in body) {
-      console.log("Zen event to confirm subscription, nothing to emit");
+      console.log("Zen event to confirm subscription, nothing to emit. Exiting");
       return;
     }
 

components/github/sources/new-push/new-push.js

@@ -4,8 +4,8 @@ module.exports = {
   ...common,
   key: "github-new-push",
   name: "New Push",
-  description: "Emit new events on each new push to a repo",
-  version: "0.0.6",
+  description: "Emit new events on each push to a repo",
+  version: "0.0.7",
   type: "source",
   dedupe: "unique",
   methods: {