Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete copy constructor of TfListenerSingleton #2862

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

furushchev
Copy link
Member

Otherwise, the copy constructor returns void which is invalid.

@furushchev
Copy link
Member Author

@k-okada
Regarding changes to support ROS-O, there seems to be a repository ros-o/jsk_recognition in addition to jsk-ros-pkg/jsk_recognition, but which one (or both?) should I send the PR to?

@k-okada
Copy link
Member

k-okada commented Feb 20, 2025

@furushchev thank you for fix, we keep our ROS-O source tree at jsk-ros-pkg, so sending PR to this repository is fine

c.f. https://github.com/v4hn/ros-o-builder/pull/26/files

@furushchev
Copy link
Member Author

@k-okada Thank you for the comment.
It might be inaccurate to ask the question here, but how do you use deb packages?
Reading the official docs [1], there are two projects that provide apt repositories:

From what I see, the former tries to use jsk-ros-pkg/jsk_recognition, and the latter still uses ros-o/jsk_recognition.
I am currently using Ubuntu 24.04, and when I tried to install ROS-O, it seems that the latter is the only option [2], but is it encouraged to migrate the latter project to use jsk-ros-pkg/jsk_recognition eventually and dual use both projects?

[1] https://github.com/ros-o/ros-o?tab=readme-ov-file#how-to-run-it
[2] Is that true? Although https://github.com/v4hn/ros-o-builder?tab=readme-ov-file#target-platforms says Ubuntu noble, I couldn't find the apt repository.

@mqcmd196
Copy link
Member

@k-okada k-okada merged commit d24721c into jsk-ros-pkg:master Feb 21, 2025
12 checks passed
@k-okada
Copy link
Member

k-okada commented Feb 21, 2025

@furushchev Actually, I was not aware of the “ubi-agni” project until @rhaschke informed me about it last week. (And I apologize for not responding to Robert yet ......) .

I would be very happy if you could send https://github.com/ubi-agni/ros-builder-action pull reqeuest using
You can use https://github.com/k-okada/ros-o-builder/blob/build-for-jammy/sources.repos e.

To pass jsk related packages on jammy, more paches ( https://github.com/v4hn/ros-deb-builder-action/pulls and https://github.com/s0/git-publish-subdir-action/pulls ) are needed and is still a work in progress for noble. I've forgotten most of it since it was a week ago, but I need to solve the missing packages for kdl and gazebo.

Last but not least information about eusilsp in 24.04, which was accidentally removed from ubuntu but is now available in ubuntu 25.04. We are also working on bringing it back in 24.04.
https://bugs.launchpad.net/ubuntu/+sources/euslisp/+bugs/2096808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants