Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config clarifications #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Config clarifications #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ end
Then start an OTP application:

```elixir
defp application do
[applications: [:xlsxir]]
def application do
[extra_applications: [:xlsxir]]
end
Comment on lines +31 to 33
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is even needed?

Applications is inferred as of Elixir 1.4. See the "Application inference" section in:
https://elixir-lang.org/blog/2017/01/05/elixir-v1-4-0-released/

Also another blog post on the topic linked via StackOverflow:
https://www.amberbit.com/blog/2017/9/22/elixir-applications-vs-extra_applications-guide/

```

Expand All @@ -40,7 +40,7 @@ end
Xlsxir parses a `.xlsx` file located at a given `path` and extracts the data to an ETS process via the `Xlsxir.multi_extract/1-5`, `Xlsxir.peek/3-4` and `Xlsxir.stream_list/2-3` functions:

```elixir
Xlsxir.multi_extract(path, index \\ nil, timer \\ false, excel \\ nil, options \\ [])
Xlsxir.multi_extract(path, index \\ nil, timer \\ false, rows \\ nil, options \\ [])
Xlsxir.peek(path, index, rows, options \\ [])
Xlsxir.stream_list(path, index, options \\ [])
```
Expand Down