Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow messageSupplier to be null. #105

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Allow messageSupplier to be null. #105

merged 2 commits into from
Dec 18, 2024

Conversation

cpovirk
Copy link
Collaborator

@cpovirk cpovirk commented Nov 6, 2024

The docs at best indirectly imply that it can be null: They have a
@throws NullPointerException clause that mentions only the case in
which obj is null, without saying anything similar about
messageSupplier.

But of course I'm actually going mostly off the implementation....

(Note that this PR is separate from
#104, which describes another
change that we could make to this parameter.)

The docs at best indirectly imply that it can be `null`: They have a
`@throws NullPointerException` clause that mentions only the case in
which `obj` is `null`, without saying anything similar about
`messageSupplier`.

But of course I'm actually going mostly off the implementation....

(Note that this PR is separate from
#104, which describes *another*
change that we could make to this parameter.)
@wmdietl wmdietl assigned cpovirk and unassigned wmdietl Dec 18, 2024
@cpovirk cpovirk merged commit f669c5b into main Dec 18, 2024
19 checks passed
@cpovirk cpovirk deleted the nullmessage branch December 18, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants