Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing right padding in the "Import symbol" example #790

Closed
nicolo-ribaudo opened this issue Oct 27, 2024 · 1 comment · Fixed by #856
Closed

Missing right padding in the "Import symbol" example #790

nicolo-ribaudo opened this issue Oct 27, 2024 · 1 comment · Fixed by #856
Labels
good first issue Good for newcomers UI/UX

Comments

@nicolo-ribaudo
Copy link
Contributor

Url: https://jsr.io/@nic/decimal-literal

image

The "Import symbol" and "Import directly with a jsr specifier" code snippets should have some right padding, similarly to how they have left padding. Ideally, it should be enough padding that (when scrolling all the way to the right) the "copy" icon does not overlap with the text.
@github-project-automation github-project-automation bot moved this to Needs Triage in JSR Oct 27, 2024
@ryuapp ryuapp mentioned this issue Oct 28, 2024
Closed
@third third mentioned this issue Oct 30, 2024
Closed
@thecoder93
Copy link
Contributor

Hi, I would like work on it. Can you assign me this, pls?

@thecoder93 thecoder93 mentioned this issue Dec 3, 2024
Merged
@crowlKats crowlKats removed the bug label Jan 16, 2025
@crowlKats crowlKats moved this from Needs Triage to In Progress in JSR Jan 16, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 12, 2025
@thecoder93 @crowlKats
fix: copy button overlaps with content (#856)
d95cf35 
Fixes #790

---------

Co-authored-by: Leo Kettmeir <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in JSR Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers UI/UX
Projects
JSR
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: copy button overlaps with content thecoder93/jsr
4 participants
@thecoder93 @nicolo-ribaudo @lucacasonato @crowlKats