Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy button overlaps with content #856

Merged
merged 7 commits into from
Mar 12, 2025
Merged

fix: copy button overlaps with content #856

merged 7 commits into from
Mar 12, 2025
+4 −0

Conversation

thecoder93
Copy link
Contributor

Fixes #790

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thecoder93
Copy link
Contributor Author

#791 is also covered by this fix.

@crowlKats
Copy link
Collaborator

@thecoder93 sorry for the delayed review. I just tested locally, but seems that the spacing is gone between the different spans:

Screenshot 2025-01-15 at 03 21 37

@thecoder93
Copy link
Contributor Author

@crowlKats
No problem for the delay.
Oh, it's strange. 🤔 I added the inline-flex. I think the problem is here. Without this it's ok but only for Chrome browser. I would like take the time to work on it.

@thecoder93 thecoder93 marked this pull request as draft March 11, 2025 13:54
@thecoder93 thecoder93 marked this pull request as ready for review March 11, 2025 14:25
@thecoder93
Copy link
Contributor Author

@crowlKats
Probably there was a mismatch with the old version of firefox or new styles were added. By removing inline-flex, with my modification it should work on both Chrome and firefox. With triple click it selects all the text. What do you think?

crowlKats
crowlKats approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good now! thanks!

@crowlKats crowlKats added this pull request to the merge queue Mar 12, 2025
@crowlKats crowlKats mentioned this pull request Mar 12, 2025
Closed
Merged via the queue into jsr-io:main with commit d95cf35 Mar 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing right padding in the "Import symbol" example
3 participants
@thecoder93 @CLAassistant @crowlKats