Skip to content

feat : Show dependencies dependents count #342 #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BorisLord
Copy link
Contributor

@BorisLord BorisLord commented Dec 4, 2024

Fixes #342.

I think a should export some code to improve visibility in of the get_handler function in package.rs into an other file but where ? utils.rs ?

Ready to read suggestions and make changes if needed !

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2024

CLA assistant check
All committers have signed the CLA.

@BorisLord BorisLord changed the title Show dependencies dependents count #342 feat : Show dependencies dependents count #342 Dec 5, 2024
@crowlKats
Copy link
Collaborator

@BorisLord overall this PR looks good to me; any reason this is marked as a draft?

@BorisLord
Copy link
Contributor Author

BorisLord commented Jan 15, 2025

@crowlKats There's no longer a good reason being marked at draft Thx

@BorisLord BorisLord marked this pull request as ready for review January 15, 2025 15:43
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting on the change to use a database COUNT instead of manual

@BorisLord BorisLord force-pushed the show-dependencies-dependents-count-#342 branch from 352d94a to a2761ab Compare February 24, 2025 22:34
@BorisLord
Copy link
Contributor Author

@crowlKats Everything looks good from my side !

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crowlKats crowlKats added this pull request to the merge queue Feb 25, 2025
Merged via the queue into jsr-io:main with commit 8cd11fe Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show number of dependencies / dependents on the web
3 participants