feat : Show dependencies dependents count #342 #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BorisLord
changed the title
crowlKats
reviewed
Jan 15, 2025
Comment on lines
+317
to
+327
| let deps = db | ||
| .list_package_version_dependencies(&scope, &package, &latest_version) | ||
| .await?; | ||
|
|
||
| api_package.dependency_count = { | ||
| let mut unique_deps = HashSet::new(); | ||
| deps | ||
| .iter() | ||
| .filter(|dep| unique_deps.insert(&dep.dependency_name)) | ||
| .count() as u64 | ||
| }; |
There was a problem hiding this comment.
maybe convert this to a database COUNT as well, especially since this is an active hotpath and recomputing this constantly seems a bit unecessary
|
@BorisLord overall this PR looks good to me; any reason this is marked as a draft? |
|
@crowlKats There's no longer a good reason being marked at draft Thx |
crowlKats
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342.
I think a should export some code to improve visibility in of the
get_handlerfunction inpackage.rsinto an other file but where ?utils.rs?Ready to read suggestions and make changes if needed !