-
Notifications
You must be signed in to change notification settings - Fork 139
feat : Show dependencies dependents count #342 #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Show dependencies dependents count #342 #857
Conversation
@BorisLord overall this PR looks good to me; any reason this is marked as a draft? |
@crowlKats There's no longer a good reason being marked at draft Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just waiting on the change to use a database COUNT instead of manual
352d94a
to
a2761ab
Compare
@crowlKats Everything looks good from my side ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #342.
I think a should export some code to improve visibility in of the
get_handler
function inpackage.rs
into an other file but where ?utils.rs
?Ready to read suggestions and make changes if needed !