-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(UI): Usage of @preact-icons/tb for icons due to $tabler_icons deprecation #938
Conversation
Co-authored-by: Augustin Mauroy <[email protected]>
Thanks :D. I missed to use those classes after testing to resize |
Why this pr is draft ? |
Keep working on it. ASAP I finish, I'll mark it as ready to review |
Co-authored-by: Augustin Mauroy <[email protected]>
…ts and update usage
…yButton component
… in score component
Hi @lucacasonato, is there any issue with using this icon for the GitHub logo? For now, it's the closest match available in the @preact-icon/tb library. |
…s/tb equivalents in PackageHeader
… equivalents in source route
IMO we should use this icon |
…eact-icons/tb equivalents in settings and versions components
…n members and versions components
… equivalents in publishing and status components
…replace with @preact-icons/tb equivalents in status route
…ub in various components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clicked around, seems good dont see any issues
Perfect, thanks :D |
Fixes #931