Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(UI): Usage of @preact-icons/tb for icons due to $tabler_icons deprecation #938

Merged
merged 17 commits into from
Feb 10, 2025

Conversation

EGAMAGZ
Copy link
Contributor

@EGAMAGZ EGAMAGZ commented Feb 7, 2025

Fixes #931

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 7, 2025

Thanks :D. I missed to use those classes after testing to resize

@AugustinMauroy
Copy link
Contributor

Why this pr is draft ?

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 7, 2025

Keep working on it. ASAP I finish, I'll mark it as ready to review

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 9, 2025

Hi @lucacasonato, is there any issue with using this icon for the GitHub logo? For now, it's the closest match available in the @preact-icon/tb library.

image

@AugustinMauroy
Copy link
Contributor

IMO we should use this icon

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 10, 2025

Fixes #932 in the commit d526b01

@EGAMAGZ EGAMAGZ marked this pull request as ready for review February 10, 2025 06:28
Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clicked around, seems good dont see any issues

@crowlKats crowlKats added this pull request to the merge queue Feb 10, 2025
@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 10, 2025

Perfect, thanks :D

Merged via the queue into jsr-io:main with commit c3f659a Feb 10, 2025
6 checks passed
@EGAMAGZ EGAMAGZ deleted the fix/tabler-icons-deprecated branch February 10, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$tabler_icons is Deprecated
3 participants