Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add social link #940

Merged
merged 3 commits into from
Feb 10, 2025
Merged

feat(ui): add social link #940

merged 3 commits into from
Feb 10, 2025

Conversation

AugustinMauroy
Copy link
Contributor

@AugustinMauroy AugustinMauroy commented Feb 7, 2025 •
edited
Loading

Capture d’écran 2025-02-07 à 16 22 22 Capture d’écran 2025-02-07 à 16 28 06

In future text link of social network can be replaced by icons

@crowlKats
Copy link
Collaborator

maybe add youtube as well?

@AugustinMauroy
Copy link
Contributor Author

maybe add youtube as well?

Good catch

@BlackAsLight
Copy link

Link: #929

@crowlKats crowlKats linked an issue Feb 10, 2025 that may be closed by this pull request
feature(front): Social network links are not on the site. #929
Closed
crowlKats
crowlKats approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@crowlKats crowlKats added this pull request to the merge queue Feb 10, 2025
Merged via the queue into jsr-io:main with commit 1984de9 Feb 10, 2025
6 checks passed
@AugustinMauroy AugustinMauroy deleted the social-network branch February 10, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature(front): Social network links are not on the site.
3 participants
@AugustinMauroy @crowlKats @BlackAsLight