Documentation fixes #133
Open
Documentation fixes #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
reviewed
Apr 3, 2020
| @@ -394,7 +394,7 @@ Enable the option `#define DISPLAY_ROTATE_180_DEGREES` in `config.h`. This shoul | |||
|
|
|||
| Edit the file `config.h` in a text editor (a command line one such as `pico`, `vim`, `nano`, or SSH map the drive to your host), and find the appropriate line in the file. Add comment lines `//` in front of that text to disable the option, or remove the `//` characters to enable it. | |||
|
|
|||
| After having edited and saved the file, reissue `make -j` in the build directory and restart fbcp-ili9341. | |||
| After having edited and saved the file, reissue ``make -j `nproc` `` in the build directory and restart fbcp-ili9341. | |||
There was a problem hiding this comment.
Hmm, is make -j not enough to get to parallel compilation? Or does that not work in some cases?
There was a problem hiding this comment.
To be honest I don't really know if -j is a problem. The docs say
If there is nothing looking like an integer after the ‘-j’ option, there is no limit on the number of job slots.
What effect that has I don't know, I'm just used to always using nproc.
There was a problem hiding this comment.
Ok, let's go with just make -j then, no need to specify the nproc.
juj
reviewed
Apr 3, 2020
|
Don't think this is a problem for a small project like this but I was doing
some Linux kernel builds yesterday where I usually use nproc and I just
used -j and my machine deadlocked and needed to be pulled from the wall :/
…On Sun, Apr 5, 2020 at 6:02 AM juj ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#133 (comment)>:
> @@ -394,7 +394,7 @@ Enable the option `#define DISPLAY_ROTATE_180_DEGREES` in `config.h`. This shoul
Edit the file `config.h` in a text editor (a command line one such as `pico`, `vim`, `nano`, or SSH map the drive to your host), and find the appropriate line in the file. Add comment lines `//` in front of that text to disable the option, or remove the `//` characters to enable it.
-After having edited and saved the file, reissue `make -j` in the build directory and restart fbcp-ili9341.
+After having edited and saved the file, reissue ``make -j `nproc` `` in the build directory and restart fbcp-ili9341.
Ok, let's go with just make -j then, no need to specify the nproc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#133 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD7JRHDN4445RPF6PG5IZRTRK77FDANCNFSM4LTPNSPA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small observations I made. Cool project, will see if I can find time to contribute.