Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mamba and micromamba release candidates #2243

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jjerphan
Copy link
Contributor

No description provided.

Signed-off-by: Julien Jerphanion <[email protected]>
@mathbunnyru
Copy link
Member

@jjerphan maybe you would like to make a contribution to this repo?
I recently changed the rules and workflows will run automatically for non first-time contributors (without having me to allow to run PRs): #2202 (comment)

The contribution you could make is to be able to specify mamba version as ARG (more or less in the spirit of this PR, but a bit more general):

  1. if default, behaves exactly like our current main branch
  2. if something-else: pin is added
  3. if rc in name, conda-forge/label/mamba_prerelease is added during installation

Would allow to test release candidates/previous versions with one line change.
And it would allow to install custom mamba versions in forks (I don't know if anyone needs it, though).

@jjerphan
Copy link
Contributor Author

jjerphan commented Feb 25, 2025

I do not want to make a contribution to this repository, I mainly want to test that the next release is not going to break docker-stacks.

Nevertheless your proposition might help such checks in the future.

@mathbunnyru
Copy link
Member

mathbunnyru commented Feb 25, 2025

I completely understand the this PR is not to be merged and just to test the new rc, just wanted to have a better process in the future, yes

@jjerphan
Copy link
Contributor Author

I am not against your proposal but I am being quite conservative: if we introduce an argument for the version of mamba, it implicitly comes with an API contract and extra maintenance for something users might not have requested and might not need; hence potentially extra maintenance costs for no benefits.

I think simply reopening this PR and adapting the version number when needed is sufficient; but feel free to implement this change (extracting part of the diff of this PR if needed).

@mathbunnyru
Copy link
Member

mathbunnyru commented Feb 25, 2025

I am not against your proposal but I am being quite conservative: if we introduce an argument for the version of mamba, it implicitly comes with an API contract and extra maintenance for something users might not have requested and might not need; hence potentially extra maintenance costs for no benefits.

Ok, I understand your point.

I think simply reopening this PR and adapting the version number when needed is sufficient; but feel free to implement this change (extracting part of the diff of this PR if needed).

Still makes me hit "Allow CI to run" button though after every commit (as I tried to explain in the very beginning), and completely defeats my proposal.

@mathbunnyru
Copy link
Member

No worries at all, just wanted to make both your and my life a tiny bit easier in the future.

@jjerphan
Copy link
Contributor Author

Still makes me hit "Allow CI to run" button though after every commit (as I explained in the very beginning), and completely defeats my proposal.

Oh yes, I forgot this. I can make another small contribution in this regards.

@mathbunnyru
Copy link
Member

Still makes me hit "Allow CI to run" button though after every commit (as I explained in the very beginning), and completely defeats my proposal.

Oh yes, I forgot this. I can make another small contribution in this regards.

Yes, would be highly appreciated. That was the whole point 🙂

@jjerphan
Copy link
Contributor Author

My mind was elsewhere.

I can have a look at a simple thing (like #2187) soon.

@mathbunnyru
Copy link
Member

mathbunnyru commented Feb 25, 2025

My mind was elsewhere.

I can have a look at a simple thing (like #2187) soon.

Thanks @jjerphan!

That might be a bit tricky because after all we haven't decided to have it or not.

Maybe fix some typo or clarify any statement in docs, doesn't have to be anything important, to be honest.
Or, even simpler: update changelog repo with PR you like in the past 4 days 🙂
https://github.com/jupyter/docker-stacks/blob/main/CHANGELOG.md

This one is good enough: #2238

@jjerphan
Copy link
Contributor Author

See #2244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants