-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mamba and micromamba release candidates #2243
base: main
Are you sure you want to change the base?
Conversation
bb8fef8
to
b0fc260
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan maybe you would like to make a contribution to this repo? The contribution you could make is to be able to specify
Would allow to test release candidates/previous versions with one line change. |
I do not want to make a contribution to this repository, I mainly want to test that the next release is not going to break Nevertheless your proposition might help such checks in the future. |
I completely understand the this PR is not to be merged and just to test the new rc, just wanted to have a better process in the future, yes |
I am not against your proposal but I am being quite conservative: if we introduce an argument for the version of mamba, it implicitly comes with an API contract and extra maintenance for something users might not have requested and might not need; hence potentially extra maintenance costs for no benefits. I think simply reopening this PR and adapting the version number when needed is sufficient; but feel free to implement this change (extracting part of the diff of this PR if needed). |
Ok, I understand your point.
Still makes me hit "Allow CI to run" button though after every commit (as I tried to explain in the very beginning), and completely defeats my proposal. |
No worries at all, just wanted to make both your and my life a tiny bit easier in the future. |
Oh yes, I forgot this. I can make another small contribution in this regards. |
Yes, would be highly appreciated. That was the whole point 🙂 |
My mind was elsewhere. I can have a look at a simple thing (like #2187) soon. |
Thanks @jjerphan! That might be a bit tricky because after all we haven't decided to have it or not. Maybe fix some typo or clarify any statement in docs, doesn't have to be anything important, to be honest. This one is good enough: #2238 |
See #2244. |
No description provided.